hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8517) Fix a decoding issue in stripped block recovering in client side
Date Wed, 03 Jun 2015 01:35:51 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570111#comment-14570111
] 

Hadoop QA commented on HDFS-8517:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  15m 17s | Findbugs (version ) appears to be broken on
HDFS-7285. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 5 new
or modified test files. |
| {color:green}+1{color} | javac |   7m 37s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 39s | There were no new javadoc warning messages.
|
| {color:red}-1{color} | release audit |   0m 15s | The applied patch generated 1 release
audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 37s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse.
|
| {color:red}-1{color} | findbugs |   3m 21s | The patch appears to introduce 1 new Findbugs
(version 3.0.0) warnings. |
| {color:green}+1{color} | native |   3m 14s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 172m 52s | Tests failed in hadoop-hdfs. |
| | | 215m  7s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs |
| Failed unit tests | hadoop.hdfs.server.namenode.TestAuditLogs |
|   | hadoop.hdfs.TestRecoverStripedFile |
|   | hadoop.hdfs.server.namenode.ha.TestHASafeMode |
|   | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS |
|   | hadoop.hdfs.server.namenode.TestFileTruncate |
|   | hadoop.hdfs.TestEncryptedTransfer |
|   | hadoop.hdfs.server.blockmanagement.TestBlockInfo |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12737015/HDFS-8517-HDFS-7285.v2.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | HDFS-7285 / 2d847e7 |
| Release Audit | https://builds.apache.org/job/PreCommit-HDFS-Build/11212/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| Findbugs warnings | https://builds.apache.org/job/PreCommit-HDFS-Build/11212/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
|
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/11212/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/11212/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/11212/console |


This message was automatically generated.

> Fix a decoding issue in stripped block recovering in client side
> ----------------------------------------------------------------
>
>                 Key: HDFS-8517
>                 URL: https://issues.apache.org/jira/browse/HDFS-8517
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>             Fix For: HDFS-7285
>
>         Attachments: HDFS-8517-HDFS-7285-v1.patch, HDFS-8517-HDFS-7285.v2.patch
>
>
> [~jingzhao] reported a decoding issue in HDFS-8481 in the comment copied below:
> bq. While debugging HDFS-8319, I just found that in TestWriteReadStripedFile#testWritePreadWithDNFailure,
if we change the startOffsetInFile from cellSize * 5 to 0, the test fails with the following
error msg:
> {noformat}
> java.lang.AssertionError: Byte at 524288 should be the same expected:<27> but was:<-9>
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.junit.Assert.failNotEquals(Assert.java:743)
> 	at org.junit.Assert.assertEquals(Assert.java:118)
> 	at org.junit.Assert.assertEquals(Assert.java:555)
> 	at org.apache.hadoop.hdfs.TestWriteReadStripedFile.testWritePreadWithDNFailure(TestWriteReadStripedFile.java:390)
> {noformat}
> It was caused by an issue that we need to adjust the inputs order to call decoder#decode.
When startOffsetInFile is 5 * cellSize, the recovering or decoding won't be needed as ZERO
cells don't need to recover; when it's 0, the issue then was exposed, as normal data cells
must be recovered thru the decoding.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message