hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rakesh R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8495) Consolidate append() related implementation into a single class
Date Tue, 02 Jun 2015 11:33:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568975#comment-14568975

Rakesh R commented on HDFS-8495:

# Checkstyle warnings:
Unused import - org.apache.hadoop.hdfs.protocol.ClientProtocol.
Unused import - org.apache.hadoop.io.EnumSetWritable.
It seems checkstyle is not considering the imports which are used in javadoc references like
{@link ClientProtocol#append(String, String, EnumSetWritable)}
# Checkstyle warning:
More than 7 parameters (found 8).
It complains about the extra arguments in the following method. I gone through the function
several times and IMHO it is good to maintain as a single function call. I couldn't find a
better way to re-factor this:(. Also, after looking into the code base I could see this comment
is not strictly followed in the project. Welcome any suggestions. Thanks!
  static LocatedBlock prepareFileForAppend(FSNamesystem fsn, String src,
      INodesInPath iip, String leaseHolder, String clientMachine,
      boolean newBlock, boolean writeToEditLog, boolean logRetryCache)
      throws IOException {

> Consolidate append() related implementation into a single class
> ---------------------------------------------------------------
>                 Key: HDFS-8495
>                 URL: https://issues.apache.org/jira/browse/HDFS-8495
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: HDFS-8495-000.patch
> This jira proposes to consolidate {{FSNamesystem#append()}} related methods into a single

This message was sent by Atlassian JIRA

View raw message