hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jitendra Nath Pandey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8457) Ozone: Refactor FsDatasetSpi to pull up HDFS-agnostic functionality into parent interface
Date Thu, 18 Jun 2015 08:01:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591433#comment-14591433
] 

Jitendra Nath Pandey commented on HDFS-8457:
--------------------------------------------

 [~arpitagarwal], this looks like a great patch. A few questions and comments: 
   # {{private boolean datasetIsFsDataset = false;}} : We could just check 'instanceof' instead
of having this variable, is there a performance concern here? Did you consider delegating
cacheReport or some parts of it to dataset implementation, that would reduce the need for
this boolean check?
   # I think getBlockLocalPathInfo assumes that it must be FsDatasetSpi, which is correct.
please add a comment for that. The same is true for a few more methods.
   # What is the reason for not moving {{public List<FinalizedReplica> getFinalizedBlocks(String
bpid)}} to DatasetSpi?
   # {{public boolean contains(ExtendedBlock block)}} can possibly move to DataSetSpi.
   # {{FsVolumeSpi}} and {{VolumeSpi}} : getPath is moved to VolumeSpi while getBasePath continues
to be in FsVolumeSpi, is that intended?
   # {{public long getAvailable() throws IOException}} should also move to VolumeSpi.
   # DataNodeTestUtils.java has only changes to imports. 


> Ozone: Refactor FsDatasetSpi to pull up HDFS-agnostic functionality into parent interface
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-8457
>                 URL: https://issues.apache.org/jira/browse/HDFS-8457
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>         Attachments: HDFS-8457-HDFS-7240.01.patch, HDFS-8457-HDFS-7240.02.patch, HDFS-8457-HDFS-7240.03.patch,
HDFS-8457-HDFS-7240.04.patch, HDFS-8457-HDFS-7240.05.patch, HDFS-8457-HDFS-7240.06.patch
>
>
> FsDatasetSpi can be split up into HDFS-specific and HDFS-agnostic parts. The HDFS-specific
parts can continue to be retained in FsDataSpi while those relating to volume management,
block pools and upgrade can be moved to a parent interface.
> There will be no change to implementations of FsDatasetSpi.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message