hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinayakumar B (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8450) Erasure Coding: Consolidate erasure coding zone related implementation into a single class
Date Mon, 01 Jun 2015 12:10:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567220#comment-14567220
] 

Vinayakumar B commented on HDFS-8450:
-------------------------------------

Hi [~rakeshr], few comments.

1. In {{FSNamesystem#createErasureCodingZone(..)}} Need to remove duplicate calls after finally
block.

{code}
+      if (success) {
+        getEditLog().logSync();
+      }
+      logAuditEvent(success, "createErasureCodingZone", srcArg, null,
+          resultingStat);
     }
     getEditLog().logSync();
     logAuditEvent(success, "createErasureCodingZone", srcArg, null, resultingStat);
{code}


2. In {{FSDirErasureCodingZoneOp.getErasureCodingZone(..)}}, {{fsn.checkOperation(OperationCategory.READ);}}
missing after aquiring the readlock. Similar check for other methods moved from FSNamesystem.

+1 once addressed.

> Erasure Coding: Consolidate erasure coding zone related implementation into a single
class
> ------------------------------------------------------------------------------------------
>
>                 Key: HDFS-8450
>                 URL: https://issues.apache.org/jira/browse/HDFS-8450
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: HDFS-8450-HDFS-7285-00.patch, HDFS-8450-HDFS-7285-01.patch, HDFS-8450-HDFS-7285-02.patch,
HDFS-8450-HDFS-7285-03.patch, HDFS-8450-HDFS-7285-04.patch
>
>
> The idea is to follow the same pattern suggested by HDFS-7416. It is good  to consolidate
all the erasure coding zone related implementations of {{FSNamesystem}}. Here, proposing {{FSDirErasureCodingZoneOp}}
class to have functions to perform related erasure coding zone operations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message