hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8388) Time and Date format need to be in sync in Namenode UI page
Date Sat, 13 Jun 2015 13:55:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584607#comment-14584607
] 

Akira AJISAKA commented on HDFS-8388:
-------------------------------------

Thanks [~surendrasingh] for taking this issue.
{code}
   @Override
-  public long getBlockDeletionStartTime() {
-    return startTime + blockManager.getStartupDelayBlockDeletionInMs();
+  public String getBlockDeletionStartTime() {
+    return Time.DATEFORMAT.get().format(
+        new Date(startTime + blockManager.getStartupDelayBlockDeletionInMs()));
   }
{code}
{code}
   @Override  // NameNodeMXBean
   public String getNNStarted() {
-    return getStartTime().toString();
+    return Time.DATEFORMAT.get().format(new Date(startTime));
   }
{code}
I'm thinking changing the return value of these method is incompatible because the method
is used for metrics and JMX. http://hadoop.apache.org/docs/r2.7.0/hadoop-project-dist/hadoop-common/Compatibility.html#MetricsJMX
Would you fix the formatting in {{helper_date_tostring}} of {{dfshealth.js}}? I've implemented
similar function in YARN WebUI by YARN-570, so you can re-use the code.

> Time and Date format need to be in sync in Namenode UI page
> -----------------------------------------------------------
>
>                 Key: HDFS-8388
>                 URL: https://issues.apache.org/jira/browse/HDFS-8388
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Archana T
>            Assignee: surendra singh lilhore
>            Priority: Minor
>         Attachments: HDFS-8388.patch
>
>
> In NameNode UI Page, Date and Time FORMAT  displayed on the page are not in sync currently.
> Started:Wed May 13 12:28:02 IST 2015
> Compiled:23 Apr 2015 12:22:59 
> Block Deletion Start Time   13 May 2015 12:28:02
> We can keep a common format in all the above places.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message