hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo Nicholas Sze (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8386) Improve synchronization of 'streamer' reference in DFSOutputStream
Date Fri, 05 Jun 2015 23:08:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575386#comment-14575386
] 

Tsz Wo Nicholas Sze commented on HDFS-8386:
-------------------------------------------

It is fine to do refactoring in trunk.  However, I think we should remove “synchronized"
from getStreamer() since it may unnecessarily block the caller and, as a result, slow down
write performance in trunk.

Let's also remove setStreamer(..) which is currently not used.  We may add it in the HDFS-7285
branch and see how to do synchronization correctly.

> Improve synchronization of 'streamer' reference in DFSOutputStream
> ------------------------------------------------------------------
>
>                 Key: HDFS-8386
>                 URL: https://issues.apache.org/jira/browse/HDFS-8386
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>             Fix For: 2.8.0
>
>         Attachments: HDFS-8386-00.patch, HDFS-8386-01.patch
>
>
> Presently {{DFSOutputStream#streamer}} object reference is accessed inconsistently with
respect to synchronization. It would be good to improve this part. This has been noticed when
implementing the erasure coding feature.
> Please refer the related [discussion thread|https://issues.apache.org/jira/browse/HDFS-8294?focusedCommentId=14541411&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14541411]
in the jira HDFS-8294 for more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message