hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhe Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8319) Erasure Coding: support decoding for stateful read
Date Thu, 04 Jun 2015 23:34:38 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573800#comment-14573800
] 

Zhe Zhang commented on HDFS-8319:
---------------------------------

The rest of the patch looks good except the 2 nits below:
# Looks like {{updateState4SuccessRead}} should be a private method of {{StatefulStripeReader}}?
# {{StatefulStripeReader#decode}}, I guess {{span}} is used to shorten code. We actually have
{{AlignedStripe#getSpanInBlock}}. We can either use that method or at least change the assignment
to {{span = (int) alignedStripe.getSpanInBlock()}}

So +1 pending the above

> Erasure Coding: support decoding for stateful read
> --------------------------------------------------
>
>                 Key: HDFS-8319
>                 URL: https://issues.apache.org/jira/browse/HDFS-8319
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-8319.001.patch, HDFS-8319.002.patch, HDFS-8319.003.patch, HDFS-8319.004.patch
>
>
> HDFS-7678 adds the decoding functionality for pread. This jira plans to add decoding
to stateful read.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message