hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5189) Rename the "CorruptBlocks" metric to "CorruptReplicas"
Date Thu, 04 Jun 2015 13:37:40 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572757#comment-14572757
] 

Hadoop QA commented on HDFS-5189:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  22m 13s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 3 new
or modified test files. |
| {color:green}+1{color} | javac |   7m 26s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 36s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does not increase
the total number of release audit warnings. |
| {color:green}+1{color} | site |   2m 57s | Site still builds. |
| {color:red}-1{color} | checkstyle |   3m 19s | The applied patch generated  1 new checkstyle
issues (total was 264, now 263). |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 31s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   5m  6s | The patch does not introduce any new Findbugs
(version 3.0.0) warnings. |
| {color:green}+1{color} | common tests |  23m 16s | Tests passed in hadoop-common. |
| {color:red}-1{color} | hdfs tests | 160m 18s | Tests failed in hadoop-hdfs. |
| | | 236m 40s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.TestDistributedFileSystem |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12737519/HDFS-5189.1.patch |
| Optional Tests | site javadoc javac unit findbugs checkstyle |
| git revision | trunk / e830207 |
| checkstyle |  https://builds.apache.org/job/PreCommit-HDFS-Build/11230/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HDFS-Build/11230/artifact/patchprocess/testrun_hadoop-common.txt
|
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/11230/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/11230/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/11230/console |


This message was automatically generated.

> Rename the "CorruptBlocks" metric to "CorruptReplicas"
> ------------------------------------------------------
>
>                 Key: HDFS-5189
>                 URL: https://issues.apache.org/jira/browse/HDFS-5189
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.1.0-beta
>            Reporter: Harsh J
>            Assignee: J.Andreina
>            Priority: Minor
>         Attachments: HDFS-5189.1.patch
>
>
> The NameNode increments a "CorruptBlocks" metric even if only one of the block's
> replicas is reported corrupt (genuine checksum fail, or even if a
> replica has a bad genstamp). In cases where this is incremented, fsck
> still reports a healthy state.
> This is confusing to users and causes false alarm as they feel this is to be monitored
(instead of MissingBlocks). The metric is truly trying to report only corrupt replicas, not
whole blocks, and ought to be renamed.
> FWIW, the "dfsadmin -report" reports a proper string of "Blocks with corrupt replicas:"
when printing this count.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message