Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BAB0B186A3 for ; Sat, 2 May 2015 05:11:17 +0000 (UTC) Received: (qmail 76919 invoked by uid 500); 2 May 2015 05:11:17 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 76829 invoked by uid 500); 2 May 2015 05:11:17 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 76683 invoked by uid 99); 2 May 2015 05:11:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 May 2015 05:11:17 +0000 Date: Sat, 2 May 2015 05:11:17 +0000 (UTC) From: "Hadoop QA (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-7469) Inline permission checking done by FSPermissionChecker#checkSubAccess MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525023#comment-14525023 ] Hadoop QA commented on HDFS-7469: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | patch | 0m 0s | The patch command could not apply the patch during dryrun. | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12686701/HDFS-7469.006.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / f1a152c | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/10695/console | This message was automatically generated. > Inline permission checking done by FSPermissionChecker#checkSubAccess > --------------------------------------------------------------------- > > Key: HDFS-7469 > URL: https://issues.apache.org/jira/browse/HDFS-7469 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Haohui Mai > Assignee: Haohui Mai > Attachments: HDFS-7469.000.patch, HDFS-7469.001.patch, HDFS-7469.002.patch, HDFS-7469.003.patch, HDFS-7469.004.patch, HDFS-7469.005.patch, HDFS-7469.006.patch > > > {{FSPermissionChecker#checkSubAccess}} is used by {{getContentSummary()}} and {{computeSnapshotDiff()}} to validate the permission of the entire subtree through BFS. > As these two calls traverse subtrees to compute the result, the permission checking should be done during the same traversal. -- This message was sent by Atlassian JIRA (v6.3.4#6332)