Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D4CE017A33 for ; Fri, 8 May 2015 16:09:19 +0000 (UTC) Received: (qmail 66417 invoked by uid 500); 8 May 2015 16:09:19 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 66371 invoked by uid 500); 8 May 2015 16:09:19 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 66358 invoked by uid 99); 8 May 2015 16:09:19 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 May 2015 16:09:19 +0000 Date: Fri, 8 May 2015 16:09:19 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-6291) FSImage may be left unclosed in BootstrapStandby#doRun() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534801#comment-14534801 ] Hudson commented on HDFS-6291: ------------------------------ FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #179 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/179/]) HDFS-6291. FSImage may be left unclosed in BootstrapStandby#doRun() ( Contributed by Sanghyun Yun) (vinayakumarb: rev e5e492a9631ff78302fccedcb64d7b64b9407991) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/BootstrapStandby.java > FSImage may be left unclosed in BootstrapStandby#doRun() > -------------------------------------------------------- > > Key: HDFS-6291 > URL: https://issues.apache.org/jira/browse/HDFS-6291 > Project: Hadoop HDFS > Issue Type: Bug > Components: ha > Reporter: Ted Yu > Assignee: Sanghyun Yun > Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-6291.2.patch, HDFS-6291.patch > > > At around line 203: > {code} > if (!checkLogsAvailableForRead(image, imageTxId, curTxId)) { > return ERR_CODE_LOGS_UNAVAILABLE; > } > {code} > If we return following the above check, image is not closed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)