hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8451) DFSClient probe for encryption testing interprets empty URI property for "enabled"
Date Thu, 21 May 2015 18:06:17 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554759#comment-14554759

Xiaoyu Yao commented on HDFS-8451:

Thanks [~steve_l] for working on this. The patch looks good to me. 
We could also fix this by checking if (dfs.getKeyProvider != null) instead of using if (dfs.isHDFSEncryptionEnabled())
in DistributedFileSystem#addDelegationTokens(). This way, invalid key provider URIs (such
as null or empty) could naturally be handled in KeyProviderCache#get(). And we could also
remove isHDFSEncryptionEnabled() which is only used in DistributedFileSystem#addDelegationTokens.

> DFSClient probe for encryption testing interprets empty URI property for "enabled"
> ----------------------------------------------------------------------------------
>                 Key: HDFS-8451
>                 URL: https://issues.apache.org/jira/browse/HDFS-8451
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: encryption
>    Affects Versions: 2.7.1
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Blocker
>         Attachments: HDFS-8451-001.patch
>   Original Estimate: 1h
>          Time Spent: 0.5h
>  Remaining Estimate: 0.5h
> HDFS-7931 added a check in DFSClient for encryption {{isHDFSEncryptionEnabled()}}, looking
for the property {{"dfs.encryption.key.provider.uri"}.
> This probe returns true even if the property is empty.
> If there is an empty provider.uri property, you get an NPE when a YARN client tries to
set up the tokens to deploy an AM.

This message was sent by Atlassian JIRA

View raw message