hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kai Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8441) Erasure Coding: make condition check earlier for setReplication
Date Wed, 20 May 2015 12:13:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552227#comment-14552227
] 

Kai Zheng commented on HDFS-8441:
---------------------------------

The patch looks good. One comment regarding the following change. Maybe we could add a method
in {{FSDirectory#isInECZone(src)}} and use it to tell the condition?
{code}
+        final ErasureCodingZoneInfo ecZoneInfo = dir.getECZoneInfo(iip);
+        if (ecZoneInfo == null) {
+          blockManager.verifyReplication(src, replication, clientMachine);
+        }
{code}

> Erasure Coding: make condition check earlier for setReplication
> ---------------------------------------------------------------
>
>                 Key: HDFS-8441
>                 URL: https://issues.apache.org/jira/browse/HDFS-8441
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Walter Su
>            Assignee: Walter Su
>         Attachments: HDFS-8441-HDFS-7285.001.patch, HDFS-8441-HDFS-7285.002.patch
>
>
> Changes:
> 1. {{UnsupportedActionException}} is more user-firendly.
> 2. check condition before update storage count
> 3. support create EC file with replication=0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message