hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8385) Remove unused entities (variables,methods and configurations)
Date Wed, 27 May 2015 10:09:17 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560724#comment-14560724
] 

Hadoop QA commented on HDFS-8385:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 39s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any
new or modified tests.  Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 29s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 35s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does not increase
the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   3m 25s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   4m 46s | The patch does not introduce any new Findbugs
(version 3.0.0) warnings. |
| {color:green}+1{color} | common tests |  23m 14s | Tests passed in hadoop-common. |
| {color:green}+1{color} | hdfs tests | 163m  3s | Tests passed in hadoop-hdfs. |
| | | 228m 42s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12735532/HDFS-8385.3.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / cdbd66b |
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HDFS-Build/11137/artifact/patchprocess/testrun_hadoop-common.txt
|
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/11137/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/11137/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/11137/console |


This message was automatically generated.

> Remove unused entities (variables,methods and configurations) 
> --------------------------------------------------------------
>
>                 Key: HDFS-8385
>                 URL: https://issues.apache.org/jira/browse/HDFS-8385
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: J.Andreina
>            Assignee: J.Andreina
>         Attachments: HDFS-8385.1.patch, HDFS-8385.2.patch, HDFS-8385.3.patch
>
>
> Below are few unused constants , methods and configurations which can be removed.
> *DfsClientConf*
>   public ChecksumOpt getDefaultChecksumOpt() {
>     return defaultChecksumOpt;
>   }
> *HdfsServerConstants*
>   long LEASE_RECOVER_PERIOD = 10 * 1000; // in ms
>   public static final String  DFS_STREAM_BUFFER_SIZE_KEY = "dfs.stream-buffer-size";
>   public static final int     DFS_STREAM_BUFFER_SIZE_DEFAULT = 4096;
> *CommonConfigurationKeys*
>   public static final String  FS_HOME_DIR_KEY = "fs.homeDir";
>   public static final String  FS_HOME_DIR_DEFAULT = "/user";
>   public static final String  IO_COMPRESSION_CODEC_LZO_BUFFERSIZE_KEY =
>     "io.compression.codec.lzo.buffersize";
>   public static final String IO_COMPRESSION_CODEC_SNAPPY_BUFFERSIZE_KEY =
>       "io.compression.codec.snappy.buffersize";



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message