hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8378) Erasure Coding: Few improvements for the erasure coding worker
Date Tue, 12 May 2015 12:29:01 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539762#comment-14539762
] 

Hadoop QA commented on HDFS-8378:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 43s | Pre-patch HDFS-7285 compilation is healthy.
|
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any
new or modified tests.  Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 30s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 39s | There were no new javadoc warning messages.
|
| {color:red}-1{color} | release audit |   0m 15s | The applied patch generated 1 release
audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 37s | There were no new checkstyle issues. |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 1  line(s) that end in whitespace.
Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 38s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse.
|
| {color:red}-1{color} | findbugs |   3m 13s | The patch appears to introduce 9 new Findbugs
(version 2.0.3) warnings. |
| {color:green}+1{color} | native |   3m 14s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 186m 58s | Tests failed in hadoop-hdfs. |
| | | 228m 24s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs |
|  |  Inconsistent synchronization of org.apache.hadoop.hdfs.DFSOutputStream.streamer; locked
89% of time  Unsynchronized access at DFSOutputStream.java:89% of time  Unsynchronized access
at DFSOutputStream.java:[line 146] |
|  |  Possible null pointer dereference of arr$ in org.apache.hadoop.hdfs.server.blockmanagement.BlockInfoStripedUnderConstruction.initializeBlockRecovery(long)
 Dereferenced at BlockInfoStripedUnderConstruction.java:arr$ in org.apache.hadoop.hdfs.server.blockmanagement.BlockInfoStripedUnderConstruction.initializeBlockRecovery(long)
 Dereferenced at BlockInfoStripedUnderConstruction.java:[line 194] |
|  |  Unread field:field be static?  At ErasureCodingWorker.java:[line 254] |
|  |  Should org.apache.hadoop.hdfs.server.datanode.erasurecode.ErasureCodingWorker$StripedReader
be a _static_ inner class?  At ErasureCodingWorker.java:inner class?  At ErasureCodingWorker.java:[lines
905-912] |
|  |  Found reliance on default encoding in org.apache.hadoop.hdfs.server.namenode.ErasureCodingZoneManager.createErasureCodingZone(String,
ECSchema):in org.apache.hadoop.hdfs.server.namenode.ErasureCodingZoneManager.createErasureCodingZone(String,
ECSchema): String.getBytes()  At ErasureCodingZoneManager.java:[line 117] |
|  |  Found reliance on default encoding in org.apache.hadoop.hdfs.server.namenode.ErasureCodingZoneManager.getECZoneInfo(INodesInPath):in
org.apache.hadoop.hdfs.server.namenode.ErasureCodingZoneManager.getECZoneInfo(INodesInPath):
new String(byte[])  At ErasureCodingZoneManager.java:[line 81] |
|  |  Dead store to counts in org.apache.hadoop.hdfs.server.namenode.INodeFile.storagespaceConsumed(BlockStoragePolicy)
 At INodeFile.java:org.apache.hadoop.hdfs.server.namenode.INodeFile.storagespaceConsumed(BlockStoragePolicy)
 At INodeFile.java:[line 833] |
|  |  Dead store to dataBlkNum in org.apache.hadoop.hdfs.util.StripedBlockUtil.calcualteChunkPositionsInBuf(ECSchema,
LocatedStripedBlock, byte[], int, int, int, int, long, int, StripedBlockUtil$AlignedStripe[])
 At StripedBlockUtil.java:org.apache.hadoop.hdfs.util.StripedBlockUtil.calcualteChunkPositionsInBuf(ECSchema,
LocatedStripedBlock, byte[], int, int, int, int, long, int, StripedBlockUtil$AlignedStripe[])
 At StripedBlockUtil.java:[line 467] |
|  |  Result of integer multiplication cast to long in org.apache.hadoop.hdfs.util.StripedBlockUtil.planReadPortions(int,
int, long, int, int)  At StripedBlockUtil.java:to long in org.apache.hadoop.hdfs.util.StripedBlockUtil.planReadPortions(int,
int, long, int, int)  At StripedBlockUtil.java:[line 206] |
| Failed unit tests | hadoop.hdfs.TestDFSPermission |
|   | hadoop.hdfs.TestErasureCodingZones |
|   | hadoop.hdfs.server.namenode.TestFSEditLogLoader |
|   | hadoop.hdfs.server.datanode.TestIncrementalBlockReports |
|   | hadoop.hdfs.TestDFSStripedInputStream |
|   | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration |
|   | hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerWithStripedBlocks |
|   | hadoop.hdfs.server.blockmanagement.TestBlockManager |
|   | hadoop.hdfs.tools.TestHdfsConfigFields |
|   | hadoop.hdfs.TestRecoverStripedFile |
|   | hadoop.hdfs.server.namenode.TestAuditLogs |
|   | hadoop.hdfs.server.namenode.TestStripedINodeFile |
|   | hadoop.hdfs.server.namenode.TestFSImage |
|   | hadoop.hdfs.TestWriteReadStripedFile |
|   | hadoop.hdfs.server.namenode.TestAddStripedBlocks |
|   | hadoop.hdfs.TestDistributedFileSystem |
|   | hadoop.tracing.TestTraceAdmin |
|   | hadoop.hdfs.server.datanode.TestBlockReplacement |
|   | hadoop.hdfs.server.datanode.TestTriggerBlockReport |
|   | hadoop.hdfs.server.blockmanagement.TestBlockInfo |
|   | hadoop.hdfs.util.TestStripedBlockUtil |
|   | hadoop.fs.TestSymlinkHdfsFileContext |
|   | hadoop.fs.TestSymlinkHdfsFileSystem |
|   | hadoop.hdfs.server.namenode.TestFileTruncate |
|   | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting |
|   | hadoop.hdfs.server.blockmanagement.TestReplicationPolicy |
| Timed out tests | org.apache.hadoop.hdfs.TestDatanodeDeath |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12732195/HDFS-8378-HDFS-7285.00.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | HDFS-7285 / 96ab5bd |
| Release Audit | https://builds.apache.org/job/PreCommit-HDFS-Build/10929/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| whitespace | https://builds.apache.org/job/PreCommit-HDFS-Build/10929/artifact/patchprocess/whitespace.txt
|
| Findbugs warnings | https://builds.apache.org/job/PreCommit-HDFS-Build/10929/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
|
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/10929/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/10929/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/10929/console |


This message was automatically generated.

> Erasure Coding: Few improvements for the erasure coding worker
> --------------------------------------------------------------
>
>                 Key: HDFS-8378
>                 URL: https://issues.apache.org/jira/browse/HDFS-8378
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>            Priority: Minor
>         Attachments: HDFS-8378-HDFS-7285.00.patch
>
>
> # Following log is confusing, make it tidy. Its missing {{break;}} statement and causing
this unwanted logs.
> {code}
> 2015-05-10 15:06:45,878 INFO  datanode.DataNode (BPOfferService.java:processCommandFromActive(728))
- DatanodeCommand action: DNA_ERASURE_CODING_RECOVERY
> 2015-05-10 15:06:45,879 WARN  datanode.DataNode (BPOfferService.java:processCommandFromActive(732))
- Unknown DatanodeCommand action: 11
> {code}
> # Add exception trace to the log, would improve debuggability
> {code}
> } catch (Throwable e) {
>    LOG.warn("Failed to recover striped block: " + blockGroup);
> }
> {code}
> # Make member variables present in ErasureCodingWorker, ReconstructAndTransferBlock,
StripedReader {{private}} {{final}}
> # Correct spelling of the variable {{STRIPED_READ_TRHEAD_POOL}} to {{STRIPED_READ_THREAD_POOL}}
> # Good to add debug logs to print the striped read pool size
> {code}
> LOG.debug("Using striped reads; pool threads=" + num);
> {code}
> # Add meaningful message to the precondition check:
> {code}
> Preconditions.checkArgument(liveIndices.length == sources.length);
> {code}
> # Remove unused import
> {code}
> import org.apache.hadoop.hdfs.server.common.HdfsServerConstants;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message