hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8364) Erasure coding: fix some minor bugs in EC CLI
Date Tue, 12 May 2015 11:49:01 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539684#comment-14539684
] 

Hadoop QA commented on HDFS-8364:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 41s | Pre-patch HDFS-7285 compilation is healthy.
|
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any
new or modified tests.  Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 30s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 37s | There were no new javadoc warning messages.
|
| {color:red}-1{color} | release audit |   0m 14s | The applied patch generated 1 release
audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 38s | There were no new checkstyle issues. |
| {color:green}+1{color} | shellcheck |   0m  4s | There were no new shellcheck (v0.3.3) issues.
|
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 34s | The patch built with eclipse:eclipse.
|
| {color:red}-1{color} | findbugs |   3m 12s | The patch appears to introduce 9 new Findbugs
(version 2.0.3) warnings. |
| {color:green}+1{color} | native |   3m 16s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 189m 32s | Tests failed in hadoop-hdfs. |
| | | 231m  0s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs |
|  |  Inconsistent synchronization of org.apache.hadoop.hdfs.DFSOutputStream.streamer; locked
89% of time  Unsynchronized access at DFSOutputStream.java:89% of time  Unsynchronized access
at DFSOutputStream.java:[line 146] |
|  |  Possible null pointer dereference of arr$ in org.apache.hadoop.hdfs.server.blockmanagement.BlockInfoStripedUnderConstruction.initializeBlockRecovery(long)
 Dereferenced at BlockInfoStripedUnderConstruction.java:arr$ in org.apache.hadoop.hdfs.server.blockmanagement.BlockInfoStripedUnderConstruction.initializeBlockRecovery(long)
 Dereferenced at BlockInfoStripedUnderConstruction.java:[line 194] |
|  |  Unread field:field be static?  At ErasureCodingWorker.java:[line 252] |
|  |  Should org.apache.hadoop.hdfs.server.datanode.erasurecode.ErasureCodingWorker$StripedReader
be a _static_ inner class?  At ErasureCodingWorker.java:inner class?  At ErasureCodingWorker.java:[lines
911-913] |
|  |  Found reliance on default encoding in org.apache.hadoop.hdfs.server.namenode.ErasureCodingZoneManager.createErasureCodingZone(String,
ECSchema):in org.apache.hadoop.hdfs.server.namenode.ErasureCodingZoneManager.createErasureCodingZone(String,
ECSchema): String.getBytes()  At ErasureCodingZoneManager.java:[line 117] |
|  |  Found reliance on default encoding in org.apache.hadoop.hdfs.server.namenode.ErasureCodingZoneManager.getECZoneInfo(INodesInPath):in
org.apache.hadoop.hdfs.server.namenode.ErasureCodingZoneManager.getECZoneInfo(INodesInPath):
new String(byte[])  At ErasureCodingZoneManager.java:[line 81] |
|  |  Dead store to counts in org.apache.hadoop.hdfs.server.namenode.INodeFile.storagespaceConsumed(BlockStoragePolicy)
 At INodeFile.java:org.apache.hadoop.hdfs.server.namenode.INodeFile.storagespaceConsumed(BlockStoragePolicy)
 At INodeFile.java:[line 833] |
|  |  Dead store to dataBlkNum in org.apache.hadoop.hdfs.util.StripedBlockUtil.calcualteChunkPositionsInBuf(ECSchema,
LocatedStripedBlock, byte[], int, int, int, int, long, int, StripedBlockUtil$AlignedStripe[])
 At StripedBlockUtil.java:org.apache.hadoop.hdfs.util.StripedBlockUtil.calcualteChunkPositionsInBuf(ECSchema,
LocatedStripedBlock, byte[], int, int, int, int, long, int, StripedBlockUtil$AlignedStripe[])
 At StripedBlockUtil.java:[line 467] |
|  |  Result of integer multiplication cast to long in org.apache.hadoop.hdfs.util.StripedBlockUtil.planReadPortions(int,
int, long, int, int)  At StripedBlockUtil.java:to long in org.apache.hadoop.hdfs.util.StripedBlockUtil.planReadPortions(int,
int, long, int, int)  At StripedBlockUtil.java:[line 206] |
| Failed unit tests | hadoop.hdfs.TestErasureCodingZones |
|   | hadoop.hdfs.util.TestStripedBlockUtil |
|   | hadoop.hdfs.server.datanode.TestIncrementalBlockReports |
|   | hadoop.hdfs.server.blockmanagement.TestBlockInfo |
|   | hadoop.hdfs.TestDFSPermission |
|   | hadoop.hdfs.TestDistributedFileSystem |
|   | hadoop.hdfs.server.datanode.TestTriggerBlockReport |
|   | hadoop.tracing.TestTraceAdmin |
|   | hadoop.hdfs.server.namenode.TestStripedINodeFile |
|   | hadoop.hdfs.server.namenode.TestFSImage |
|   | hadoop.hdfs.TestDFSStripedInputStream |
|   | hadoop.hdfs.TestParallelUnixDomainRead |
|   | hadoop.hdfs.TestRecoverStripedFile |
|   | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting |
|   | hadoop.hdfs.server.namenode.TestAuditLogs |
|   | hadoop.hdfs.server.blockmanagement.TestBlockManager |
|   | hadoop.hdfs.server.namenode.TestFSEditLogLoader |
|   | hadoop.hdfs.server.namenode.TestFileTruncate |
|   | hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewerWithStripedBlocks |
|   | hadoop.hdfs.server.datanode.TestBlockReplacement |
|   | hadoop.fs.TestSymlinkHdfsFileSystem |
|   | hadoop.hdfs.TestWriteReadStripedFile |
|   | hadoop.hdfs.tools.TestHdfsConfigFields |
|   | hadoop.fs.TestSymlinkHdfsFileContext |
| Timed out tests | org.apache.hadoop.hdfs.server.namenode.TestAddStripedBlocks |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12732178/HDFS-8364-HDFS-7285.001.patch
|
| Optional Tests | javadoc javac unit shellcheck findbugs checkstyle |
| git revision | HDFS-7285 / 96ab5bd |
| Release Audit | https://builds.apache.org/job/PreCommit-HDFS-Build/10927/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| Findbugs warnings | https://builds.apache.org/job/PreCommit-HDFS-Build/10927/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
|
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/10927/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/10927/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/10927/console |


This message was automatically generated.

> Erasure coding: fix some minor bugs in EC CLI
> ---------------------------------------------
>
>                 Key: HDFS-8364
>                 URL: https://issues.apache.org/jira/browse/HDFS-8364
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Walter Su
>            Assignee: Walter Su
>            Priority: Minor
>         Attachments: HDFS-8364-HDFS-7285.001.patch
>
>
> issue 1:  it's  not user-friendly. We should tell user that `hdfs erasurecode`  is the
entrance to EC commands(HDFS-7349)
> {noformat}
>  # bin/hdfs
> Usage: hdfs [--config confdir] [--daemon (start|stop|status)]
>            [--loglevel loglevel] COMMAND
>        where COMMAND is one of:
>   balancer             run a cluster balancing utility
>   cacheadmin           configure the HDFS cache
>   crypto               configure HDFS encryption zones
>   ...
>   zkfc                 run the ZK Failover Controller daemon
> {noformat}
> issue 2: it's not user-friendly
> {noformat}
>  # bin/hdfs erasurecode -getZoneInfo /
> -getZoneInfo: Fatal internal error
> java.lang.NullPointerException
>         at org.apache.hadoop.hdfs.tools.erasurecode.ECCommand$GetECZoneInfoCommand.processPath(ECCommand.java:168)
>         at org.apache.hadoop.fs.shell.Command.processPaths(Command.java:321)
>         at org.apache.hadoop.fs.shell.Command.processPathArgument(Command.java:293)
>         at org.apache.hadoop.fs.shell.Command.processArgument(Command.java:275)
>         at org.apache.hadoop.fs.shell.Command.processArguments(Command.java:259)
>         at org.apache.hadoop.fs.shell.Command.processRawArguments(Command.java:205)
>         at org.apache.hadoop.fs.shell.Command.run(Command.java:166)
>         at org.apache.hadoop.fs.FsShell.run(FsShell.java:291)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
>         at org.apache.hadoop.hdfs.tools.erasurecode.ECCli.main(ECCli.java:45)
> {noformat}
> possible issue 3: We create zone twice at /
> {noformat}
>  # bin/hdfs erasurecode -createZone /
> EC Zone created successfully at hdfs://ds-34:9000/
>  # bin/hdfs erasurecode -createZone /
> createZone: Unable to create EC zone for the path hdfs://ds-34:9000/
> {noformat}
> It doesn't print detail error message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message