hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8327) Compute storage type quotas in INodeFile.computeQuotaDeltaForTruncate()
Date Fri, 08 May 2015 18:44:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535222#comment-14535222
] 

Jing Zhao commented on HDFS-8327:
---------------------------------

Thanks for working on this code refactoring, Haohui! The patch looks good. The only issue
is in {{FileWithSnapshotFeature#updateQuotaAndCollectBlocks}}, in the new code {{oldCounts}}'s
quota usage for each storage type is actually based on the new replication factor (i.e., the
rep. after removing the file diff).

> Compute storage type quotas in INodeFile.computeQuotaDeltaForTruncate()
> -----------------------------------------------------------------------
>
>                 Key: HDFS-8327
>                 URL: https://issues.apache.org/jira/browse/HDFS-8327
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>              Labels: BB2015-05-TBR
>         Attachments: HDFS-8327.000.patch, HDFS-8327.001.patch, HDFS-8327.002.patch, HDFS-8327.003.patch
>
>
> To simplify the code {{INodeFile.computeQuotaDeltaForTruncate()}} can compute the storage
type quotas as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message