hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8321) CacheDirectives and CachePool operations should throw RetriableException in safemode
Date Tue, 05 May 2015 04:30:07 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527885#comment-14527885
] 

Hadoop QA commented on HDFS-8321:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 39s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any
new or modified tests.  Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 27s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 34s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does not increase
the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 42s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   3m  3s | The patch does not introduce any new Findbugs
(version 2.0.3) warnings. |
| {color:green}+1{color} | native |   3m 13s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 168m 48s | Tests failed in hadoop-hdfs. |
| | | 210m  3s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.server.namenode.TestCacheDirectives |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12730312/HDFS-8321.000.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / d701acc |
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/10797/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/10797/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/10797/console |


This message was automatically generated.

> CacheDirectives and CachePool operations should throw RetriableException in safemode
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-8321
>                 URL: https://issues.apache.org/jira/browse/HDFS-8321
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-8321.000.patch
>
>
> Operations such as {{addCacheDirectives()}} throws {{SafeModeException}} when the NN
is in safemode:
> {code}
>       if (isInSafeMode()) {
>         throw new SafeModeException(
>             "Cannot add cache directive", safeMode);
>       }
> {code}
> While other NN operations throws {{RetriableException}} when HA is enabled:
> {code}
>   void checkNameNodeSafeMode(String errorMsg)
>       throws RetriableException, SafeModeException {
>     if (isInSafeMode()) {
>       SafeModeException se = new SafeModeException(errorMsg, safeMode);
>       if (haEnabled && haContext != null
>           && haContext.getState().getServiceState() == HAServiceState.ACTIVE
>           && shouldRetrySafeMode(this.safeMode)) {
>         throw new RetriableException(se);
>       } else {
>         throw se;
>       }
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message