hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lei (Eddy) Xu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-8306) Generate ACL and Xattr outputs in OIV XML outputs
Date Mon, 04 May 2015 20:07:08 GMT

     [ https://issues.apache.org/jira/browse/HDFS-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lei (Eddy) Xu updated HDFS-8306:
--------------------------------
    Attachment: HDFS-8306.001.patch

Thanks a lot for reviewing, [~andrew.wang]

bq. I think xattr keys can be binary too, so would need to base64 them too.

In {{o.a.h.fs.XAttr}}:

{code}
public class XAttr {
...
  private final String name;
  private final byte[] value;
}
{code}

It should indicate that {{name}} has no intention to be binary data. The current code can
handle UTF-8 and escape chars well, I added tests in the updated patch.

bq. In this case, I'd really like to see a compile time error saying that support for this
new data hasn't been added to OIV.

Yeah, it is a nice function to have. Lets do it in a follow on JIRA?

Could you give another review? Thanks!

> Generate ACL and Xattr outputs in OIV XML outputs
> -------------------------------------------------
>
>                 Key: HDFS-8306
>                 URL: https://issues.apache.org/jira/browse/HDFS-8306
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 2.7.0
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>            Priority: Minor
>         Attachments: HDFS-8306.000.patch, HDFS-8306.001.patch
>
>
> Currently, in the {{hdfs oiv}} XML outputs, not all fields of fsimage are outputs. It
makes inspecting {{fsimage}} from XML outputs less practical. Also it prevents recovering
a fsimage from XML file.
> This JIRA is adding ACL and XAttrs in the XML outputs as the first step to achieve the
goal described in HDFS-8061.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message