hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8305) HDFS INotify: the destination field of RenameOp should always end with the file name
Date Mon, 04 May 2015 22:11:07 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527437#comment-14527437
] 

Hadoop QA commented on HDFS-8305:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 31s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 1 new
or modified test files. |
| {color:green}+1{color} | javac |   7m 29s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 40s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does not increase
the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   2m 14s | There were no new checkstyle issues. |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 1  line(s) that end in whitespace.
Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 34s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   3m  2s | The patch does not introduce any new Findbugs
(version 2.0.3) warnings. |
| {color:green}+1{color} | native |   3m 13s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 167m  1s | Tests failed in hadoop-hdfs. |
| | | 209m 47s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.TestAppendSnapshotTruncate |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12730236/HDFS-8305.002.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / c457876 |
| whitespace | https://builds.apache.org/job/PreCommit-HDFS-Build/10788/artifact/patchprocess/whitespace.txt
|
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/10788/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/10788/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/10788/console |


This message was automatically generated.

> HDFS INotify: the destination field of RenameOp should always end with the file name
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-8305
>                 URL: https://issues.apache.org/jira/browse/HDFS-8305
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-8305.001.patch, HDFS-8305.002.patch
>
>
> HDFS INotify: the destination field of RenameOp should always end with the file name
rather than sometimes being a directory name.  Previously, in some cases when using the old
rename, this was not the case.  The format of OP_EDIT_LOG_RENAME_OLD allows moving /f to /d/f
to be represented as RENAME(src=/f, dst=/d) or RENAME(src=/f, dst=/d/f). This change makes
HDFS always use the latter form. This, in turn, ensures that inotify will always be able to
consider the dst field as the full destination file name. This is a compatible change since
we aren't removing the ability to handle the first form during edit log replay... we just
no longer generate it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message