hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rakesh R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8294) Erasure Coding: Fix Findbug warnings present in erasure coding
Date Wed, 13 May 2015 06:00:02 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541411#comment-14541411
] 

Rakesh R commented on HDFS-8294:
--------------------------------

Thanks [~zhz] for the review.

bq. Please see if you want to separate out the getStreamer() refactor to trunk.
I hope you are suggesting me to raise a separate jira to improve the {{streamer}} access by
introducing {{#getStreamer()}} method. Subject of the new jira would be like: "Improve synchronization
of 'streamer' reference in DFSOutputStream - accessed inconsistently with respect to synchronization".
ok?

bq. In general I feel we should make a pass in how we handle long and int types in striping
logic (in particular, StripedBlockUtil. Rakesh R do you want to take the lead given the related
work on this JIRA?
Yes, I'm happy to help. Shall we address this point through separate jira. Subject would be
like: "Revisit the long and int datatypes usage in striping logic"?

> Erasure Coding: Fix Findbug warnings present in erasure coding
> --------------------------------------------------------------
>
>                 Key: HDFS-8294
>                 URL: https://issues.apache.org/jira/browse/HDFS-8294
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>              Labels: BB2015-05-RFC
>         Attachments: FindBugs Report in EC feature.html, HDFS-8294-HDFS-7285.00.patch,
HDFS-8294-HDFS-7285.01.patch, HDFS-8294-HDFS-7285.02.patch, HDFS-8294-HDFS-7285.03.patch
>
>
> This jira is to address the findbug issues reported in erasure coding feature.
> Attached sheet which contains the details of the findbug issues reported in the erasure
coding feature. I've taken this report from the jenkins build : 
> https://builds.apache.org/job/PreCommit-HDFS-Build/10848/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message