hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8294) Erasure Coding: Fix Findbug warnings present in erasure coding
Date Thu, 07 May 2015 20:54:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533364#comment-14533364
] 

Hadoop QA commented on HDFS-8294:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  15m  7s | Pre-patch HDFS-7285 compilation is healthy.
|
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any
new or modified tests.  Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 38s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 43s | There were no new javadoc warning messages.
|
| {color:red}-1{color} | release audit |   3m 55s | The applied patch generated 76 release
audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 37s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  3s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   3m 11s | The patch does not introduce any new Findbugs
(version 2.0.3) warnings. |
| {color:green}+1{color} | native |   3m 14s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 177m  1s | Tests failed in hadoop-hdfs. |
| | | 222m 49s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.hdfs.TestRecoverStripedFile |
|   | hadoop.hdfs.server.namenode.TestAuditLogs |
|   | hadoop.hdfs.server.namenode.TestFileTruncate |
|   | hadoop.hdfs.server.namenode.TestTransferFsImage |
|   | hadoop.hdfs.util.TestByteArrayManager |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12731220/HDFS-8294-HDFS-7285.03.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | HDFS-7285 / c61c9c8 |
| Release Audit | https://builds.apache.org/job/PreCommit-HDFS-Build/10849/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/10849/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/10849/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/10849/console |


This message was automatically generated.

> Erasure Coding: Fix Findbug warnings present in erasure coding
> --------------------------------------------------------------
>
>                 Key: HDFS-8294
>                 URL: https://issues.apache.org/jira/browse/HDFS-8294
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>              Labels: BB2015-05-TBR
>         Attachments: HDFS-8294-HDFS-7285.00.patch, HDFS-8294-HDFS-7285.01.patch, HDFS-8294-HDFS-7285.02.patch,
HDFS-8294-HDFS-7285.03.patch
>
>
> Following are the findbug warnings :-
> # Possible null pointer dereference of arr$ in org.apache.hadoop.hdfs.server.blockmanagement.BlockInfoStripedUnderConstruction.initializeBlockRecovery(long)
> {code}
> Bug type NP_NULL_ON_SOME_PATH (click for details) 
> In class org.apache.hadoop.hdfs.server.blockmanagement.BlockInfoStripedUnderConstruction
> In method org.apache.hadoop.hdfs.server.blockmanagement.BlockInfoStripedUnderConstruction.initializeBlockRecovery(long)
> Value loaded from arr$
> Dereferenced at BlockInfoStripedUnderConstruction.java:[line 206]
> Known null at BlockInfoStripedUnderConstruction.java:[line 200]
> {code}
> # Found reliance on default encoding in org.apache.hadoop.hdfs.server.namenode.ErasureCodingZoneManager.createErasureCodingZone(String,
ECSchema): String.getBytes()
> Found reliance on default encoding in org.apache.hadoop.hdfs.server.namenode.ErasureCodingZoneManager.getECZoneInfo(INodesInPath):
new String(byte[])
> {code}
> Bug type DM_DEFAULT_ENCODING (click for details) 
> In class org.apache.hadoop.hdfs.server.namenode.ErasureCodingZoneManager
> In method org.apache.hadoop.hdfs.server.namenode.ErasureCodingZoneManager.createErasureCodingZone(String,
ECSchema)
> Called method String.getBytes()
> At ErasureCodingZoneManager.java:[line 116]
> Bug type DM_DEFAULT_ENCODING (click for details) 
> In class org.apache.hadoop.hdfs.server.namenode.ErasureCodingZoneManager
> In method org.apache.hadoop.hdfs.server.namenode.ErasureCodingZoneManager.getECZoneInfo(INodesInPath)
> Called method new String(byte[])
> At ErasureCodingZoneManager.java:[line 81]
> {code}
> # Inconsistent synchronization of org.apache.hadoop.hdfs.DFSOutputStream.streamer; locked
90% of time
> {code}
> Bug type IS2_INCONSISTENT_SYNC (click for details) 
> In class org.apache.hadoop.hdfs.DFSOutputStream
> Field org.apache.hadoop.hdfs.DFSOutputStream.streamer
> Synchronized 90% of the time
> Unsynchronized access at DFSOutputStream.java:[line 142]
> Unsynchronized access at DFSOutputStream.java:[line 853]
> Unsynchronized access at DFSOutputStream.java:[line 617]
> Unsynchronized access at DFSOutputStream.java:[line 620]
> Unsynchronized access at DFSOutputStream.java:[line 630]
> Unsynchronized access at DFSOutputStream.java:[line 338]
> Unsynchronized access at DFSOutputStream.java:[line 734]
> Unsynchronized access at DFSOutputStream.java:[line 897]
> {code}
> # Dead store to offSuccess in org.apache.hadoop.hdfs.StripedDataStreamer.endBlock()
> {code}
> Bug type DLS_DEAD_LOCAL_STORE (click for details) 
> In class org.apache.hadoop.hdfs.StripedDataStreamer
> In method org.apache.hadoop.hdfs.StripedDataStreamer.endBlock()
> Local variable named offSuccess
> At StripedDataStreamer.java:[line 105]
> {code}
> # Result of integer multiplication cast to long in org.apache.hadoop.hdfs.server.blockmanagement.BlockInfoStriped.spaceConsumed()
> {code}
> Bug type ICAST_INTEGER_MULTIPLY_CAST_TO_LONG (click for details) 
> In class org.apache.hadoop.hdfs.server.blockmanagement.BlockInfoStriped
> In method org.apache.hadoop.hdfs.server.blockmanagement.BlockInfoStriped.spaceConsumed()
> At BlockInfoStriped.java:[line 208]
> {code}
> # Result of integer multiplication cast to long in org.apache.hadoop.hdfs.util.StripedBlockUtil.constructInternalBlock(LocatedStripedBlock,
int, int, int, int)
> {code}
> Bug type ICAST_INTEGER_MULTIPLY_CAST_TO_LONG (click for details) 
> In class org.apache.hadoop.hdfs.util.StripedBlockUtil
> In method org.apache.hadoop.hdfs.util.StripedBlockUtil.constructInternalBlock(LocatedStripedBlock,
int, int, int, int)
> At StripedBlockUtil.java:[line 85]
> {code}
> # Switch statement found in org.apache.hadoop.hdfs.DFSStripedInputStream.fetchBlockByteRange(long,
long, long, byte[], int, Map) where default case is missing
> {code}
> Bug type SF_SWITCH_NO_DEFAULT (click for details) 
> In class org.apache.hadoop.hdfs.DFSStripedInputStream
> In method org.apache.hadoop.hdfs.DFSStripedInputStream.fetchBlockByteRange(long, long,
long, byte[], int, Map)
> At DFSStripedInputStream.java:[lines 468-491]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message