hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8237) Move all protocol classes used by ClientProtocol to hdfs-client
Date Mon, 04 May 2015 00:11:06 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526099#comment-14526099
] 

Hadoop QA commented on HDFS-8237:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 40s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any
new or modified tests.  Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 28s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 36s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 22s | The applied patch does not increase
the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle |   0m 59s | The applied patch generated  33 new checkstyle
issues (total was 51, now 84). |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with eclipse:eclipse.
|
| {color:red}-1{color} | findbugs |   3m 47s | The patch appears to introduce 8 new Findbugs
(version 2.0.3) warnings. |
| {color:green}+1{color} | native |   3m 13s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 165m  8s | Tests passed in hadoop-hdfs. |
| {color:green}+1{color} | hdfs tests |   0m 17s | Tests passed in hadoop-hdfs-client. |
| | | 207m 42s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs-client |
|  |  org.apache.hadoop.hdfs.protocol.SnapshotDiffReport$DiffReportEntry.getSourcePath() may
expose internal representation by returning SnapshotDiffReport$DiffReportEntry.sourcePath
 At SnapshotDiffReport.java:by returning SnapshotDiffReport$DiffReportEntry.sourcePath  At
SnapshotDiffReport.java:[line 133] |
|  |  org.apache.hadoop.hdfs.protocol.SnapshotDiffReport$DiffReportEntry.getTargetPath() may
expose internal representation by returning SnapshotDiffReport$DiffReportEntry.targetPath
 At SnapshotDiffReport.java:by returning SnapshotDiffReport$DiffReportEntry.targetPath  At
SnapshotDiffReport.java:[line 137] |
|  |  new org.apache.hadoop.hdfs.protocol.SnapshotDiffReport$DiffReportEntry(SnapshotDiffReport$DiffType,
byte[], byte[]) may expose internal representation by storing an externally mutable object
into SnapshotDiffReport$DiffReportEntry.sourcePath  At SnapshotDiffReport.java:expose internal
representation by storing an externally mutable object into SnapshotDiffReport$DiffReportEntry.sourcePath
 At SnapshotDiffReport.java:[line 98] |
|  |  new org.apache.hadoop.hdfs.protocol.SnapshotDiffReport$DiffReportEntry(SnapshotDiffReport$DiffType,
byte[], byte[]) may expose internal representation by storing an externally mutable object
into SnapshotDiffReport$DiffReportEntry.targetPath  At SnapshotDiffReport.java:expose internal
representation by storing an externally mutable object into SnapshotDiffReport$DiffReportEntry.targetPath
 At SnapshotDiffReport.java:[line 99] |
|  |  org.apache.hadoop.hdfs.protocol.SnapshottableDirectoryStatus.getParentFullPath() may
expose internal representation by returning SnapshottableDirectoryStatus.parentFullPath  At
SnapshottableDirectoryStatus.java:by returning SnapshottableDirectoryStatus.parentFullPath
 At SnapshottableDirectoryStatus.java:[line 88] |
|  |  new org.apache.hadoop.hdfs.protocol.SnapshottableDirectoryStatus(long, long, FsPermission,
String, String, byte[], long, int, int, int, byte[]) may expose internal representation by
storing an externally mutable object into SnapshottableDirectoryStatus.parentFullPath  At
SnapshottableDirectoryStatus.java:String, byte[], long, int, int, int, byte[]) may expose
internal representation by storing an externally mutable object into SnapshottableDirectoryStatus.parentFullPath
 At SnapshottableDirectoryStatus.java:[line 67] |
|  |  org.apache.hadoop.hdfs.server.protocol.DatanodeStorageReport.getStorageReports() may
expose internal representation by returning DatanodeStorageReport.storageReports  At DatanodeStorageReport.java:by
returning DatanodeStorageReport.storageReports  At DatanodeStorageReport.java:[line 40] |
|  |  new org.apache.hadoop.hdfs.server.protocol.DatanodeStorageReport(DatanodeInfo, StorageReport[])
may expose internal representation by storing an externally mutable object into DatanodeStorageReport.storageReports
 At DatanodeStorageReport.java:internal representation by storing an externally mutable object
into DatanodeStorageReport.storageReports  At DatanodeStorageReport.java:[line 32] |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12730010/HDFS-8237.001.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / a319771 |
| checkstyle |  https://builds.apache.org/job/PreCommit-HDFS-Build/10762/artifact/patchprocess/diffcheckstylehadoop-hdfs-client.txt
|
| Findbugs warnings | https://builds.apache.org/job/PreCommit-HDFS-Build/10762/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs-client.html
|
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/10762/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| hadoop-hdfs-client test log | https://builds.apache.org/job/PreCommit-HDFS-Build/10762/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/10762/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/10762/console |


This message was automatically generated.

> Move all protocol classes used by ClientProtocol to hdfs-client
> ---------------------------------------------------------------
>
>                 Key: HDFS-8237
>                 URL: https://issues.apache.org/jira/browse/HDFS-8237
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: build
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-8237.000.patch, HDFS-8237.001.patch
>
>
> This jira proposes to move the classes in the hdfs project referred by ClientProtocol
into the hdfs-client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message