hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7758) Retire FsDatasetSpi#getVolumes() and use FsDatasetSpi#getVolumeRefs() instead
Date Tue, 05 May 2015 01:48:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527759#comment-14527759
] 

Hadoop QA commented on HDFS-7758:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch |   0m  0s | The patch command could not apply the patch during
dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12730329/HDFS-7758.009.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 551615f |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/10799/console |


This message was automatically generated.

> Retire FsDatasetSpi#getVolumes() and use FsDatasetSpi#getVolumeRefs() instead
> -----------------------------------------------------------------------------
>
>                 Key: HDFS-7758
>                 URL: https://issues.apache.org/jira/browse/HDFS-7758
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>    Affects Versions: 2.6.0
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>         Attachments: HDFS-7758.000.patch, HDFS-7758.001.patch, HDFS-7758.002.patch, HDFS-7758.003.patch,
HDFS-7758.004.patch, HDFS-7758.005.patch, HDFS-7758.006.patch, HDFS-7758.007.patch, HDFS-7758.008.patch,
HDFS-7758.009.patch
>
>
> HDFS-7496 introduced reference-counting  the volume instances being used to prevent race
condition when hot swapping a volume.
> However, {{FsDatasetSpi#getVolumes()}} can still leak the volume instance without increasing
its reference count. In this JIRA, we retire the {{FsDatasetSpi#getVolumes()}} and propose
{{FsDatasetSpi#getVolumeRefs()}} and etc. method to access {{FsVolume}}. Thus it makes sure
that the consumer of {{FsVolume}} always has correct reference count.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message