hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kihwal Lee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7728) Avoid updating quota usage while loading edits
Date Fri, 08 May 2015 14:07:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534588#comment-14534588
] 

Kihwal Lee commented on HDFS-7728:
----------------------------------

The patch looked good before the existing code got reorganized. [~jingzhao], can you update
the patch?

> Avoid updating quota usage while loading edits
> ----------------------------------------------
>
>                 Key: HDFS-7728
>                 URL: https://issues.apache.org/jira/browse/HDFS-7728
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>              Labels: BB2015-05-TBR
>         Attachments: HDFS-7728.000.patch, HDFS-7728.001.patch
>
>
> Per the discussion [here|https://issues.apache.org/jira/browse/HDFS-7611?focusedCommentId=14292454&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14292454],
currently we call {{INode#addSpaceConsumed}} while file/dir/snapshot deletion, even if this
is still in the edits loading process. This is unnecessary and can cause issue like HDFS-7611.
We should collect quota change and call {{FSDirectory#updateCount}} at the end of the operation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message