hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rakesh R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5640) Add snapshot methods to FileContext.
Date Fri, 08 May 2015 15:31:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534716#comment-14534716
] 

Rakesh R commented on HDFS-5640:
--------------------------------

Following checkstyle issues reported by jenkins and those are unrelated to my patch.
- HDFS:
{code}
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:382:3:
Method length is 205 lines (max allowed is 150).
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:463:28:
Expression can be simplified.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:463:55:
Expression can be simplified.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:382:3:
Method length is 205 lines (max allowed is 150).
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:463:28:
Expression can be simplified.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:463:55:
Expression can be simplified.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:382:3:
Method length is 205 lines (max allowed is 150).
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:463:28:
Expression can be simplified.
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:463:55:
Expression can be simplified.
{code}
- Hadoop_Common
{code}
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java:1:
File length is 2,668 lines (max allowed is 2,000).
{code}

Secondly testcase failure is also unrelated to my patch.

Kindly review the changes. Thanks!

> Add snapshot methods to FileContext.
> ------------------------------------
>
>                 Key: HDFS-5640
>                 URL: https://issues.apache.org/jira/browse/HDFS-5640
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client, snapshots
>    Affects Versions: 3.0.0, 2.2.0
>            Reporter: Chris Nauroth
>            Assignee: Rakesh R
>              Labels: BB2015-05-RFC
>         Attachments: HDFS-5640-001.patch, HDFS-5640-002.patch, HDFS-5640-003.patch, HDFS-5640-004.patch,
HDFS-5640-005.patch, HDFS-5640-007.patch, HDFS-5640-007.patch
>
>
> Currently, methods related to HDFS snapshots are defined on {{FileSystem}}.  For feature
parity, these methods need to be added to {{FileContext}}.  This would also require updating
{{AbstractFileSystem}} and the {{Hdfs}} subclass.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message