hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3643) hdfsJniHelper.c unchecked string pointers
Date Sat, 02 May 2015 23:02:06 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525538#comment-14525538
] 

Hadoop QA commented on HDFS-3643:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |   5m  6s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any
new or modified tests.  Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 24s | There were no new javac warning messages. |
| {color:green}+1{color} | release audit |   0m 19s | The applied patch does not increase
the total number of release audit warnings. |
| {color:green}+1{color} | whitespace |   0m  1s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 32s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | native |   1m  8s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 165m 41s | Tests passed in hadoop-hdfs. |
| | | 181m 48s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12729957/HDFS-3643.02.patch
|
| Optional Tests | javac unit |
| git revision | trunk / 6ae2a0d |
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/10720/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/10720/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/10720/console |


This message was automatically generated.

> hdfsJniHelper.c unchecked string pointers
> -----------------------------------------
>
>                 Key: HDFS-3643
>                 URL: https://issues.apache.org/jira/browse/HDFS-3643
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: libhdfs
>    Affects Versions: 2.0.0-alpha
>            Reporter: Andy Isaacson
>            Assignee: Andy Isaacson
>         Attachments: HDFS-3643.02.patch, hdfs-3643-1.txt, hdfs3643-2.txt, hdfs3643.txt
>
>
> {code}
>     str = methSignature;
>     while (*str != ')') str++;
>     str++;
>     returnType = *str;
> {code}
> This loop needs to check for {{'\0'}}. Also the following {{if/else if/else if}} cascade
doesn't handle unexpected values.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message