Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3218517AC0 for ; Tue, 21 Apr 2015 18:15:59 +0000 (UTC) Received: (qmail 69523 invoked by uid 500); 21 Apr 2015 18:15:59 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 69461 invoked by uid 500); 21 Apr 2015 18:15:59 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 69449 invoked by uid 99); 21 Apr 2015 18:15:58 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Apr 2015 18:15:58 +0000 Date: Tue, 21 Apr 2015 18:15:58 +0000 (UTC) From: "Jing Zhao (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8200) Refactor FSDirStatAndListingOp MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505416#comment-14505416 ] Jing Zhao commented on HDFS-8200: --------------------------------- The patch looks good to me. One minor is that we can also pass the INodeAttributes into {{createFileStatus(..., needLocation, ...)}} to make the style more consistent. +1 after addressing the comments. > Refactor FSDirStatAndListingOp > ------------------------------ > > Key: HDFS-8200 > URL: https://issues.apache.org/jira/browse/HDFS-8200 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Haohui Mai > Assignee: Haohui Mai > Attachments: HDFS-8200.000.patch > > > After HDFS-6826 several functions in {{FSDirStatAndListingOp}} are dead. This jira proposes to clean them up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)