Return-Path: 
 <hdfs-issues-return-118351-apmail-hadoop-hdfs-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 822C8176E1
	for <apmail-hadoop-hdfs-issues-archive@minotaur.apache.org>;
 Wed, 22 Apr 2015 13:42:02 +0000 (UTC)
Received: (qmail 22380 invoked by uid 500); 22 Apr 2015 13:42:02 -0000
Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org
Received: (qmail 22320 invoked by uid 500); 22 Apr 2015 13:42:02 -0000
Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:hdfs-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:hdfs-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:hdfs-issues@hadoop.apache.org>
List-Id: <hdfs-issues.hadoop.apache.org>
Reply-To: hdfs-issues@hadoop.apache.org
Delivered-To: mailing list hdfs-issues@hadoop.apache.org
Received: (qmail 22308 invoked by uid 99); 22 Apr 2015 13:42:02 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Apr 2015 13:42:02 +0000
Date: Wed, 22 Apr 2015 13:42:02 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12821637.1429210575000.75273.1429710122062@Atlassian.JIRA>
In-Reply-To: <JIRA.12821637.1429210575000@Atlassian.JIRA>
References: <JIRA.12821637.1429210575000@Atlassian.JIRA>
 <JIRA.12821637.1429210575342@arcas>
Subject: [jira] [Commented] (HDFS-8163) Using monotonicNow for block report
 scheduling causes test failures on recently restarted systems
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HDFS-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507087#comment-14507087 ] 

Hudson commented on HDFS-8163:
------------------------------

FAILURE: Integrated in Hadoop-Mapreduce-trunk #2121 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2121/])
HDFS-8163. Using monotonicNow for block report scheduling causes test failures on recently restarted systems. (Arpit Agarwal) (arp: rev dfc1c4c303cf15afc6c3361ed9d3238562f73cbd)
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Time.java
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBpServiceActorScheduler.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java


> Using monotonicNow for block report scheduling causes test failures on recently restarted systems
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-8163
>                 URL: https://issues.apache.org/jira/browse/HDFS-8163
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 2.6.1
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>            Priority: Blocker
>             Fix For: 2.7.1
>
>         Attachments: HDFS-8163.01.patch, HDFS-8163.02.patch, HDFS-8163.03.patch
>
>
> {{BPServiceActor#blockReport}} has the following check:
> {code}
>   List<DatanodeCommand> blockReport() throws IOException {
>     // send block report if timer has expired.
>     final long startTime = monotonicNow();
>     if (startTime - lastBlockReport <= dnConf.blockReportInterval) {
>       return null;
>     }
> {code}
> Many tests trigger an immediate block report via {{BPServiceActor#triggerBlockReportForTests}} which sets {{lastBlockReport = 0}}. However if the machine was restarted recently then startTime may be less than {{dnConf.blockReportInterval}} and the block report is not sent.
> {{Time#monotonicNow}} uses {{System#nanoTime}} which represents time elapsed since an arbitrary origin. The time should be used only for comparison with other values returned by {{System#nanoTime}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)