Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 42897178F7 for ; Tue, 14 Apr 2015 05:03:13 +0000 (UTC) Received: (qmail 63577 invoked by uid 500); 14 Apr 2015 05:03:13 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 63521 invoked by uid 500); 14 Apr 2015 05:03:13 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 63509 invoked by uid 99); 14 Apr 2015 05:03:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Apr 2015 05:03:13 +0000 Date: Tue, 14 Apr 2015 05:03:12 +0000 (UTC) From: "Jing Zhao (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8127) NameNode Failover during HA upgrade can cause DataNode to finalize upgrade MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493563#comment-14493563 ] Jing Zhao commented on HDFS-8127: --------------------------------- Thanks for the review, Nicholas! bq. BootstrapStandby may format shared directories since storage.format(..) will format all directories including the shared directories. This is an existing bug I think the shared dir will not be formatted here, because {{editUrisToFormat}} only contains local dirs. I will update the patch to address your other comments and fix the failed unit tests. > NameNode Failover during HA upgrade can cause DataNode to finalize upgrade > -------------------------------------------------------------------------- > > Key: HDFS-8127 > URL: https://issues.apache.org/jira/browse/HDFS-8127 > Project: Hadoop HDFS > Issue Type: Bug > Components: ha > Affects Versions: 2.4.0 > Reporter: Jing Zhao > Assignee: Jing Zhao > Priority: Blocker > Attachments: HDFS-8127.000.patch > > > Currently for HA upgrade (enabled by HDFS-5138), we use {{-bootstrapStandby}} to initialize the standby NameNode. The standby NameNode does not have the {{previous}} directory thus it does not know that the cluster is in the upgrade state. If NN failover happens, as response of block reports, the new ANN will tell DNs to finalize the upgrade thus make it impossible to rollback again. -- This message was sent by Atlassian JIRA (v6.3.4#6332)