Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BD9FB17E47 for ; Mon, 13 Apr 2015 22:51:12 +0000 (UTC) Received: (qmail 79433 invoked by uid 500); 13 Apr 2015 22:51:12 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 79369 invoked by uid 500); 13 Apr 2015 22:51:12 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 79357 invoked by uid 99); 13 Apr 2015 22:51:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Apr 2015 22:51:12 +0000 Date: Mon, 13 Apr 2015 22:51:12 +0000 (UTC) From: "Hadoop QA (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8117) More accurate verification in SimulatedFSDataset: replace DEFAULT_DATABYTE with patterned data MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493216#comment-14493216 ] Hadoop QA commented on HDFS-8117: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12725021/HDFS-8117.003.patch against trunk revision 7fc50e2. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 6 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10263//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10263//console This message is automatically generated. > More accurate verification in SimulatedFSDataset: replace DEFAULT_DATABYTE with patterned data > ---------------------------------------------------------------------------------------------- > > Key: HDFS-8117 > URL: https://issues.apache.org/jira/browse/HDFS-8117 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 2.6.0 > Reporter: Zhe Zhang > Assignee: Zhe Zhang > Fix For: 3.0.0 > > Attachments: HDFS-8117-branch2.patch, HDFS-8117.000.patch, HDFS-8117.001.patch, HDFS-8117.002.patch, HDFS-8117.003.patch > > > Currently {{SimulatedFSDataset}} uses a single {{DEFAULT_DATABYTE}} to simulate _all_ block content. This is not accurate because the return of this byte just means the read request has hit an arbitrary position in an arbitrary simulated block. > This JIRA aims to improve it with a more accurate verification. When position {{p}} of a simulated block {{b}} is accessed, the returned byte is {{b}}'s block ID plus {{p}}, moduled by the max value of a byte. -- This message was sent by Atlassian JIRA (v6.3.4#6332)