Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EE50C17519 for ; Thu, 9 Apr 2015 11:56:19 +0000 (UTC) Received: (qmail 91817 invoked by uid 500); 9 Apr 2015 11:56:19 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 91769 invoked by uid 500); 9 Apr 2015 11:56:19 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 91757 invoked by uid 99); 9 Apr 2015 11:56:19 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Apr 2015 11:56:19 +0000 Date: Thu, 9 Apr 2015 11:56:19 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8076) Code cleanup for DFSInputStream: use offset instead of LocatedBlock when possible MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487244#comment-14487244 ] Hudson commented on HDFS-8076: ------------------------------ SUCCESS: Integrated in Hadoop-Yarn-trunk #892 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/892/]) HDFS-8076. Code cleanup for DFSInputStream: use offset instead of LocatedBlock when possible. Contributed by Zhe Zhang. (wang: rev a42bb1cd915abe5dc33eda3c01e8c74c64f35748) * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java > Code cleanup for DFSInputStream: use offset instead of LocatedBlock when possible > --------------------------------------------------------------------------------- > > Key: HDFS-8076 > URL: https://issues.apache.org/jira/browse/HDFS-8076 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Zhe Zhang > Assignee: Zhe Zhang > Fix For: 2.8.0 > > Attachments: HDFS-8076-000.patch > > > This JIRA aims to refactor the signatures {{fetchBlockByteRange}} and {{actualGetFromOneDataNode}}. Instead of taking a {{LocatedBlock}}, I think they should just take the starting offset of that block, since they'll later call {{getBlockAt}} to refresh the location anyway. I think we should make it clear so the callers are not surprised if the finally used {{LocatedBlock}} is not the one they passed in. -- This message was sent by Atlassian JIRA (v6.3.4#6332)