Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7EF2A17537 for ; Sat, 4 Apr 2015 14:37:37 +0000 (UTC) Received: (qmail 9792 invoked by uid 500); 4 Apr 2015 14:37:36 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 9732 invoked by uid 500); 4 Apr 2015 14:37:36 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 9649 invoked by uid 99); 4 Apr 2015 14:37:36 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Apr 2015 14:37:36 +0000 Date: Sat, 4 Apr 2015 14:37:36 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8051) FsVolumeList#addVolume should release volume reference if not put it into BlockScanner. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395756#comment-14395756 ] Hudson commented on HDFS-8051: ------------------------------ SUCCESS: Integrated in Hadoop-Hdfs-trunk #2085 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2085/]) HDFS-8051. FsVolumeList#addVolume should release volume reference if not put it into BlockScanner. (Lei (Eddy) Xu via Colin P. McCabe) (cmccabe: rev ef591b1d6a08f08358b19763a874de6010227307) * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsVolumeList.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt > FsVolumeList#addVolume should release volume reference if not put it into BlockScanner. > --------------------------------------------------------------------------------------- > > Key: HDFS-8051 > URL: https://issues.apache.org/jira/browse/HDFS-8051 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode > Affects Versions: 2.6.0 > Reporter: Lei (Eddy) Xu > Assignee: Lei (Eddy) Xu > Fix For: 2.7.0 > > Attachments: HDFS-8051.000.patch > > > {{FsVolumeList#addVolume()}} passes {{FsVolumeReference}} to blockScanner: > {code} > if (blockScanner != null) { > blockScanner.addVolumeScanner(ref); > } > {code} > However, if {{blockScanner == null}}, the {{FsVolumeReference}} will not be released. -- This message was sent by Atlassian JIRA (v6.3.4#6332)