Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 6 Apr 2015 23:23:12 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12787264.1427869856000.9017.1428362592231@Atlassian.JIRA>
In-Reply-To: <JIRA.12787264.1427869856000@Atlassian.JIRA>
References: <JIRA.12787264.1427869856000@Atlassian.JIRA>
 <JIRA.12787264.1427869856110@arcas>
Subject: [jira] [Commented] (HDFS-8038) PBImageDelimitedTextWriter#getEntry
 output HDFS path in platform-specific format.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482182#comment-14482182 ] 

Hadoop QA commented on HDFS-8038:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12723426/HDFS-8038.02.patch
  against trunk revision 28bebc8.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.TestFileCreation

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10182//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10182//console

This message is automatically generated.

> PBImageDelimitedTextWriter#getEntry output HDFS path in platform-specific format.
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-8038
>                 URL: https://issues.apache.org/jira/browse/HDFS-8038
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: tools
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>            Priority: Minor
>         Attachments: HDFS-8038.00.patch, HDFS-8038.01.patch, HDFS-8038.02.patch
>
>
> PBImageDelimitedTextWriter#getEntry taking the HDFS path and passing it through java.io.File, which causes platform-specific behavior as the actual results shown in TestOfflineImageViewer#testPBDelimitedWriter() on Windows OS.
> {code}
> expected:<[/emptydir, /dir0, /dir1/file2, /dir1, /dir1/file3, /dir2/file3, /dir1/file0, /dir1/file1, /dir2/file1, /dir2/file2, /dir2, /dir0/file0, /dir2/file0, /dir0/file1, /dir0/file2, /dir0/file3, /xattr]> 
> but was:<[\dir0, \dir0\file3, \dir0\file2, \dir0\file1, \xattr, \emptydir, \dir0\file0, \dir1\file1, \dir1\file0, \dir1\file3, \dir1\file2, \dir2\file3, \, \dir1, \dir2\file0, \dirContainingInvalidXMLChar&#0;here, \dir2, \dir2\file2, \dir2\file1]>
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)