Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1319F17BCC for ; Wed, 1 Apr 2015 00:34:54 +0000 (UTC) Received: (qmail 61468 invoked by uid 500); 1 Apr 2015 00:34:53 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 61409 invoked by uid 500); 1 Apr 2015 00:34:53 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 61391 invoked by uid 99); 1 Apr 2015 00:34:53 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Apr 2015 00:34:53 +0000 Date: Wed, 1 Apr 2015 00:34:53 +0000 (UTC) From: "Colin Patrick McCabe (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-8026) Trace FSOutputSummer#writeChecksumChunks rather than DFSOutputStream#writeChunk MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-8026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389768#comment-14389768 ] Colin Patrick McCabe commented on HDFS-8026: -------------------------------------------- I think the previous test timeout on {{TestTracing}} was not related to this patch, since it didn't reproduce the second time I ran it on JIRA. I also can't reproduce it locally. This patch is not really changing how {{TestTracing}} works, just tweaking a string that it's looking for, so I would not expect it to regress this. While it's kind of unfortunate that the test (may be?) flaky, I think we should not let that block this patch. I'm going to commit in just a bit... if we hit more timeouts on {{TestTracing}}, we'll have to have a separate JIRA to investigate. Thanks, [~hitliuyi]. > Trace FSOutputSummer#writeChecksumChunks rather than DFSOutputStream#writeChunk > ------------------------------------------------------------------------------- > > Key: HDFS-8026 > URL: https://issues.apache.org/jira/browse/HDFS-8026 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 2.7.0 > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Priority: Minor > Attachments: HDFS-8026.001.patch > > > We should trace FSOutputSummer#writeChecksumChunks rather than DFSOutputStream#writeChunk. When tracing writeChunk, we get a new trace span every 512 bytes; when tracing writeChecksumChunks, we normally get a new trace span only when the FSOutputSummer buffer is full (9x less often.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)