Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 34E3D175AD for ; Tue, 7 Apr 2015 16:47:30 +0000 (UTC) Received: (qmail 59394 invoked by uid 500); 7 Apr 2015 16:47:14 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 59334 invoked by uid 500); 7 Apr 2015 16:47:14 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 59321 invoked by uid 99); 7 Apr 2015 16:47:14 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Apr 2015 16:47:14 +0000 Date: Tue, 7 Apr 2015 16:47:14 +0000 (UTC) From: "Zhe Zhang (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-7955) Improve naming of classes, methods, and variables related to block replication and recovery MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14483481#comment-14483481 ] Zhe Zhang commented on HDFS-7955: --------------------------------- [~rakeshr] Great! Do you want to write a patch based on this conclusion? Thanks.. > Improve naming of classes, methods, and variables related to block replication and recovery > ------------------------------------------------------------------------------------------- > > Key: HDFS-7955 > URL: https://issues.apache.org/jira/browse/HDFS-7955 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Zhe Zhang > Assignee: Rakesh R > > Many existing names should be revised to avoid confusion when blocks can be both replicated and erasure coded. This JIRA aims to solicit opinions on making those names more consistent and intuitive. > # In current HDFS _block recovery_ refers to the process of finalizing the last block of a file, triggered by _lease recovery_. It is different from the intuitive meaning of _recovering a lost block_. To avoid confusion, I can think of 2 options: > #* Rename this process as _block finalization_ or _block completion_. I prefer this option because this is literally not a recovery. > #* If we want to keep existing terms unchanged we can name all EC recovery and re-replication logics as _reconstruction_. > # As Kai [suggested | https://issues.apache.org/jira/browse/HDFS-7369?focusedCommentId=14361131&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14361131] under HDFS-7369, several replication-based names should be made more generic: > #* {{UnderReplicatedBlocks}} and {{neededReplications}}. E.g. we can use {{LowRedundancyBlocks}}/{{AtRiskBlocks}}, and {{neededRecovery}}/{{neededReconstruction}}. > #* {{PendingReplicationBlocks}} > #* {{ReplicationMonitor}} > I'm sure the above list is incomplete; discussions and comments are very welcome. -- This message was sent by Atlassian JIRA (v6.3.4#6332)