Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B1F1917764 for ; Thu, 16 Apr 2015 06:57:59 +0000 (UTC) Received: (qmail 10623 invoked by uid 500); 16 Apr 2015 06:57:59 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 10573 invoked by uid 500); 16 Apr 2015 06:57:59 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 10560 invoked by uid 99); 16 Apr 2015 06:57:59 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Apr 2015 06:57:59 +0000 Date: Thu, 16 Apr 2015 06:57:59 +0000 (UTC) From: "Rakesh R (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-7949) WebImageViewer need support file size calculation with striped blocks MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497646#comment-14497646 ] Rakesh R commented on HDFS-7949: -------------------------------- Thanks [~zhz] for the review. bq. Maybe we should wait for that and then move the static {{spaceConsumed}} method to there? IIUC your suggestion is to move the {{#spaceConsumed}} function to {{StripedBlockUtil}} utility, isn't it? Thanks [~drankye] for the review. bq. below codes, the assertion isn't clear to me. For assertion, I'm using {{fileStatus.toString()}} representation which contains {{length}} attribute info. Now, its hard coded value. As per the [~zhz] suggestion, I will update using {{#spaceConsumed}} function directly. Does this sound good to you? > WebImageViewer need support file size calculation with striped blocks > --------------------------------------------------------------------- > > Key: HDFS-7949 > URL: https://issues.apache.org/jira/browse/HDFS-7949 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Hui Zheng > Assignee: Rakesh R > Priority: Minor > Attachments: HDFS-7949-001.patch, HDFS-7949-002.patch, HDFS-7949-003.patch, HDFS-7949-004.patch > > > The file size calculation should be changed when the blocks of the file are striped in WebImageViewer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)