Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 7 Apr 2015 09:15:13 +0000 (UTC)
From: "Li Bo (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12779685.1425529323000.12802.1428398113016@Atlassian.JIRA>
In-Reply-To: <JIRA.12779685.1425529323000@Atlassian.JIRA>
References: <JIRA.12779685.1425529323000@Atlassian.JIRA>
 <JIRA.12779685.1425529323466@arcas>
Subject: [jira] [Commented] (HDFS-7889) Subclass DFSOutputStream to support
 writing striping layout files
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/HDFS-7889?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D14482=
890#comment-14482890 ]=20

Li Bo commented on HDFS-7889:
-----------------------------

hi, Zhe
Thanks for your review and update of patch.

1.=09will fix it
2.=09Yes, we can come back to modify it after related subtasks are ready.
3.=09in {{encode()}},  just copy the references of buffer in order to call =
raw coder=E2=80=99s encode function
4.=09Different streamers share the same {{ExtendedBlock}}, so I think we ca=
n use any of them.
5.=09Yes, that's a good point. Will fix it.
6.=09Not very clear about your meaning. What hook? DFSStripedOutputStream i=
s created in previous sentence {{os =3D fs.create(TestPath);}}
7.=09Could we set the limit to 90  or 100 chars? 80 chars seem a little sho=
rt, and there=E2=80=99re many lines with more than 80 chars(<100) in curren=
t code.
8.=09Yes, will verify parity data content in the unit test. One problem is =
if the last block group is smaller than  a stripe, only 3 block locations w=
ill  be returned after calling {{fs.getClient().getLocationBlocks(src, 0L)}=
}. Could you have a check about this problem?


> Subclass DFSOutputStream to support writing striping layout files
> -----------------------------------------------------------------
>
>                 Key: HDFS-7889
>                 URL: https://issues.apache.org/jira/browse/HDFS-7889
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Li Bo
>            Assignee: Li Bo
>         Attachments: HDFS-7889-001.patch, HDFS-7889-002.patch, HDFS-7889-=
003.patch, HDFS-7889-004.patch, HDFS-7889-005.patch, HDFS-7889-006.patch, H=
DFS-7889-007.patch, HDFS-7889-008.patch, HDFS-7889-009.patch
>
>
> After HDFS-7888, we can subclass  {{DFSOutputStream}} to support writing =
striping layout files.=20


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)