hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8272) Erasure Coding: simplify the retry logic in DFSStripedInputStream
Date Wed, 29 Apr 2015 08:53:06 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518982#comment-14518982
] 

Yi Liu commented on HDFS-8272:
------------------------------

Thanks Jing for the work and Zhe for the review !

{quote}
-          if (pos > blockEnd || currentNodes == null) {
-            currentNodes = blockSeekTo(pos);
-          }
+        if (pos > blockEnd) {
+          blockSeekTo(pos);
+        }
{quote}
We should keep {{currentNodes == null}} ?  Otherwise {{blockReaders}} is not initialized?

{code}
private int fetchEncryptionKeyTimes = 2;
private int fetchTokenTimes = 2;
{code}
Should them be {{1}}?




> Erasure Coding: simplify the retry logic in DFSStripedInputStream
> -----------------------------------------------------------------
>
>                 Key: HDFS-8272
>                 URL: https://issues.apache.org/jira/browse/HDFS-8272
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: h8272-HDFS-7285.000.patch, h8272-HDFS-7285.001.patch
>
>
> Currently in DFSStripedInputStream the retry logic is still the same with DFSInputStream.
More specifically, every failed read will try to search for another source node. And an exception
is thrown when no new source node can be identified. This logic is not appropriate for EC
inputstream and can be simplified.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message