hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8249) Separate HdfsConstants into the client and the server side class
Date Thu, 30 Apr 2015 05:14:07 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520877#comment-14520877
] 

Hadoop QA commented on HDFS-8249:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 37s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 37 new
or modified test files. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | javac |   7m 33s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 31s | There were no new javadoc warning messages.
|
| {color:red}-1{color} | release audit |   0m 19s | The applied patch generated 1 release
audit warnings. |
| {color:red}-1{color} | checkstyle |   7m 43s | The applied patch generated  22  additional
checkstyle issues. |
| {color:green}+1{color} | install |   1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with eclipse:eclipse.
|
| {color:red}-1{color} | findbugs |   5m  4s | The patch appears to introduce 1 new Findbugs
(version 2.0.3) warnings. |
| {color:green}+1{color} | native |   3m 15s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 224m 57s | Tests failed in hadoop-hdfs. |
| {color:green}+1{color} | hdfs tests |   0m 16s | Tests passed in hadoop-hdfs-client. |
| {color:green}+1{color} | hdfs tests |   2m 42s | Tests passed in hadoop-hdfs-nfs. |
| {color:green}+1{color} | hdfs tests |   4m  1s | Tests passed in bkjournal. |
| | | 282m 15s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs |
|  |  Class org.apache.hadoop.hdfs.DataStreamer$LastException is not derived from an Exception,
even though it is named as such  At DataStreamer.java:from an Exception, even though it is
named as such  At DataStreamer.java:[lines 178-202] |
| Failed unit tests | hadoop.hdfs.TestDFSClientRetries |
|   | hadoop.hdfs.TestDFSOutputStream |
|   | hadoop.hdfs.server.namenode.TestDeleteRace |
|   | hadoop.hdfs.TestClose |
|   | hadoop.hdfs.server.datanode.fsdataset.impl.TestRbwSpaceReservation |
|   | hadoop.hdfs.server.datanode.TestBlockRecovery |
|   | hadoop.cli.TestHDFSCLI |
|   | hadoop.hdfs.server.namenode.TestFileTruncate |
|   | hadoop.hdfs.TestCrcCorruption |
|   | hadoop.hdfs.TestMultiThreadedHflush |
|   | hadoop.hdfs.TestQuota |
|   | hadoop.hdfs.TestFileLengthOnClusterRestart |
| Timed out tests | org.apache.hadoop.hdfs.TestDataTransferProtocol |
|   | org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery |
|   | org.apache.hadoop.hdfs.server.namenode.TestNamenodeRetryCache |
|   | org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12729355/HDFS-8249.002.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 4c1af15 |
| Release Audit | https://builds.apache.org/job/PreCommit-HDFS-Build/10463/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/10463/artifact/patchprocess/checkstyle-result-diff.txt
|
| Findbugs warnings | https://builds.apache.org/job/PreCommit-HDFS-Build/10463/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
|
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/10463/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| hadoop-hdfs-client test log | https://builds.apache.org/job/PreCommit-HDFS-Build/10463/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
|
| hadoop-hdfs-nfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/10463/artifact/patchprocess/testrun_hadoop-hdfs-nfs.txt
|
| bkjournal test log | https://builds.apache.org/job/PreCommit-HDFS-Build/10463/artifact/patchprocess/testrun_bkjournal.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/10463/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/10463/console |


This message was automatically generated.

> Separate HdfsConstants into the client and the server side class
> ----------------------------------------------------------------
>
>                 Key: HDFS-8249
>                 URL: https://issues.apache.org/jira/browse/HDFS-8249
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-8249.000.patch, HDFS-8249.001.patch, HDFS-8249.002.patch
>
>
> The constants in {{HdfsConstants}} are used by both the client side and the server side.
There are two types of constants in the class:
> 1. Constants that are used internally by the servers or not part of the APIs. These constants
are free to evolve without breaking compatibilities. For example, {{MAX_PATH_LENGTH}} is used
by the NN to enforce the length of the path does not go too long. Developers are free to change
the name of the constants and to move it around if necessary.
> 1. Constants that are used by the clients, but not parts of the APIs. For example, {{QUOTA_DONT_SET}}
represents an unlimited quota. The value is part of the wire protocol but the value is not.
Developers are free to rename the constants but are not allowed to change the value of the
constants.
> 1. Constants that are parts of the APIs. For example, {{SafeModeAction}} is used in {{DistributedFileSystem}}.
Changing the name / value of the constant will break binary compatibility, but not source
code compatibility.
> This jira proposes to separate the above three types of constants into different classes:
> * Creating a new class {{HdfsConstantsServer}} to hold the first type of constants.
> * Move {{HdfsConstants}} into the {{hdfs-client}} package. The work of separating the
second and the third types of constants will be postponed in a separate jira.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message