hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinayakumar B (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8231) StackTrace displayed at client while QuotaByStorageType exceeds
Date Fri, 24 Apr 2015 06:27:38 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510533#comment-14510533
] 

Vinayakumar B commented on HDFS-8231:
-------------------------------------

Thanks for the latest patch.
bq. Though logically this is correct, but it will not avoid logging stacktrace. Because RemoteException#unwrapRemoteException(..)
compares just the classnames, not instanceof.
Along with the above fix suggested by Chris Nauroth, Still I recommend to extend QuotaByStorageTypeExceededException
from DSQuotaExceededException and remove call to super.getMessage() in QuotaByStorageTypeExceededException#getMessage()
to get the correct message.
I see some problems with getting the right message after extending.
Since the exceptions are not carrying all the arguments from server-client, other than message
and trace, if {{getMessage()}} gets updated will get NPE at client side, because {{type}}
will be null.
So conclusion is, *NOT* to extend, and keep it to Earlier suggestion by [~cnauroth].
Apologies for all noice :)

[~andreina], can you re-upload the patch by removing changes in {{QuotaByStorageTypeExceededException.java}}
?

> StackTrace displayed at client while QuotaByStorageType exceeds
> ---------------------------------------------------------------
>
>                 Key: HDFS-8231
>                 URL: https://issues.apache.org/jira/browse/HDFS-8231
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>            Reporter: J.Andreina
>            Assignee: J.Andreina
>            Priority: Minor
>         Attachments: HDFS-8231.00.patch, HDFS-8231.1.patch
>
>
> StackTrace displayed at client while QuotaByStorageType exceeds.
> With reference to HDFS-2360, feel better to fix this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message