hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Takanobu Asanuma (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-8215) Refactor NamenodeFsck#check method
Date Thu, 23 Apr 2015 10:53:39 GMT

     [ https://issues.apache.org/jira/browse/HDFS-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Takanobu Asanuma updated HDFS-8215:
-----------------------------------
    Attachment: HDFS-8215.1.patch

I created a first patch. There may be some task to do refactoring.

# The main change in this patch is creating some methods to reduce the length of Namenodefsck#check.
# I confirmed that TestFsck was passed.
# As an aside, I'm trying to support the fsck for Erasure Coding in HDFS-7687. I think we
will create Namenodefsck#collectECBlockGroupsSummary, like Namenodefsck#collectBlocksSummary
I created in this patch.

Please review it. Thank you.

> Refactor NamenodeFsck#check method
> ----------------------------------
>
>                 Key: HDFS-8215
>                 URL: https://issues.apache.org/jira/browse/HDFS-8215
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Takanobu Asanuma
>            Assignee: Takanobu Asanuma
>         Attachments: HDFS-8215.1.patch
>
>
> This method is very long, approximately 230 lines. Splitting this method into smaller
methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message