hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8214) Secondary NN Web UI shows wrong date for Last Checkpoint
Date Mon, 27 Apr 2015 18:12:39 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514585#comment-14514585
] 

Andrew Wang commented on HDFS-8214:
-----------------------------------

Hi Charles, this patch looks good, only two comments:

* Since we return 0 for the delta when no checkpoint has been done, we can't distinguish this
situation from a checkpoint having been just completed. We could also check the wallclock
time, but so we can interpret the delta in isolation, how about returning a -1 value in this
situation instead?
* We get the monotonic time before calling doCheckpoint, and set the member variable after
it finishes. Could we do the same with the wallclock time for parity? doCheckpoint takes some
time, so as is they won't match up quite right.

> Secondary NN Web UI shows wrong date for Last Checkpoint
> --------------------------------------------------------
>
>                 Key: HDFS-8214
>                 URL: https://issues.apache.org/jira/browse/HDFS-8214
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: HDFS, namenode
>    Affects Versions: 2.7.0
>            Reporter: Charles Lamb
>            Assignee: Charles Lamb
>         Attachments: HDFS-8214.001.patch, HDFS-8214.002.patch
>
>
> SecondaryNamenode is using Time.monotonicNow() to display Last Checkpoint in the web
UI. This causes weird times, generally, just after the epoch, to be displayed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message