hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinayakumar B (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HDFS-8189) ClientProtocol#createErasureCodingZone API was wrongly annotated as Idempotent
Date Tue, 28 Apr 2015 08:58:06 GMT

     [ https://issues.apache.org/jira/browse/HDFS-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Vinayakumar B resolved HDFS-8189.
---------------------------------
       Resolution: Fixed
    Fix Version/s: HDFS-7285
     Hadoop Flags: Reviewed

Committed to HDFS-7285 branch.
Thanks [~umamaheswararao] for the review.

> ClientProtocol#createErasureCodingZone API was wrongly annotated as Idempotent
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-8189
>                 URL: https://issues.apache.org/jira/browse/HDFS-8189
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Uma Maheswara Rao G
>            Assignee: Vinayakumar B
>             Fix For: HDFS-7285
>
>         Attachments: HDFS-8189-01.patch
>
>
> Currently createErasureCodingZone was annotated as Idempotent
> But it should be annotated as @AtMostOnce as we handle retries via retryCache.
> {code}
>  @Idempotent
>   public void createErasureCodingZone(String src, ECSchema schema)
>       throws IOException;
> {code}
> It will fail to create Zone if its already a zone. So, simply we can not retry by ignoring
previous call success. So, we were using retryCache already for handling this situation.
> {code}
>  if (getECSchema(srcIIP) != null) {
>       throw new IOException("Directory " + src + " is already in an " +
>           "erasure coding zone.");
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message