hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo Nicholas Sze (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8188) Erasure coding: refactor client-related code to sync with HDFS-8082 and HDFS-8169
Date Mon, 20 Apr 2015 21:05:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503612#comment-14503612
] 

Tsz Wo Nicholas Sze commented on HDFS-8188:
-------------------------------------------

- When configedStripedPoolSize <= 0 below, it should throw an exception.  
{code}
+    if (configedStripedPoolSize <= 0) {
+      DFSClient.LOG.warn("The value of "
+          + HdfsClientConfigKeys.StripedRead.THREADPOOL_SIZE_KEY
+          + " must be greater than 0. The current setting is " +
+          configedStripedPoolSize + ". Reset it to the default value "
+          + HdfsClientConfigKeys.StripedRead.THREADPOOL_SIZE_DEFAULT);
+      stripedReadThreadpoolSize =
+          HdfsClientConfigKeys.StripedRead.THREADPOOL_SIZE_DEFAULT;
+    } else {
{code}
- The comment below seems wrong.  Also it should be changed to javadoc.
{code}
+    // With default 3+2 schema, each normal read could span 3 DNs. So this
+    // default value accommodates 6 read streams
+    int     THREADPOOL_SIZE_DEFAULT = 18;
{code}


> Erasure coding: refactor client-related code to sync with HDFS-8082 and HDFS-8169
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-8188
>                 URL: https://issues.apache.org/jira/browse/HDFS-8188
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Zhe Zhang
>            Assignee: Zhe Zhang
>         Attachments: HDFS-8188.000.patch, HDFS-8188.for8082.patch
>
>
> HDFS-8082 and HDFS-8169 refactors client-side config keys and classes. This JIRA tracks
changes to keep EC code in sync with these changes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message