hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hui Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8167) BlockManager.addBlockCollectionWithCheck should check if the block is a striped block
Date Fri, 17 Apr 2015 09:45:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499555#comment-14499555
] 

Hui Zheng commented on HDFS-8167:
---------------------------------

This is because the test case used a StripedId(which < 0) for a BlockInfoContiguous.
After [HDFS-7994|https://issues.apache.org/jira/browse/HDFS-7994] ,it will fail if the BlockManager
doesn't correctly initialize the "hasNonEcBlockUsingStripedID" by loading fsimage or editlog.
I will update this patch as following:
{code}
@@ -1202,7 +1202,7 @@ public void testAddStoredBlockDoesNotCauseSkippedReplication()
     BlockManager bm = new BlockManager(mockNS, new HdfsConfiguration());
     UnderReplicatedBlocks underReplicatedBlocks = bm.neededReplications;
 
-    BlockInfo block1 = genBlockInfo(random.nextLong());
+   BlockInfo block1 = genBlockInfo(Math.abs(random.nextLong()));
     BlockInfo block2 = genBlockInfo(random.nextLong());
{code}

> BlockManager.addBlockCollectionWithCheck should check if the block is a striped block
> -------------------------------------------------------------------------------------
>
>                 Key: HDFS-8167
>                 URL: https://issues.apache.org/jira/browse/HDFS-8167
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Hui Zheng
>         Attachments: HDFS-8167_001.patch
>
>
> This JIRA is to address [~zhz]'s [comment|https://issues.apache.org/jira/browse/HDFS-7994?focusedCommentId=14498894&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14498894].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message