hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-8163) Using monotonicNow for block report scheduling causes test failures on recently restarted systems
Date Sat, 18 Apr 2015 00:40:59 GMT

     [ https://issues.apache.org/jira/browse/HDFS-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Arpit Agarwal updated HDFS-8163:
--------------------------------
    Attachment: HDFS-8163.03.patch

Updated v03 patch to handle negative values and overflows. Split out the timestamp manipulation
into a nested class Scheduler.

Reviews welcome!

> Using monotonicNow for block report scheduling causes test failures on recently restarted
systems
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-8163
>                 URL: https://issues.apache.org/jira/browse/HDFS-8163
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 2.6.1
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>            Priority: Blocker
>         Attachments: HDFS-8163.01.patch, HDFS-8163.02.patch, HDFS-8163.03.patch
>
>
> {{BPServiceActor#blockReport}} has the following check:
> {code}
>   List<DatanodeCommand> blockReport() throws IOException {
>     // send block report if timer has expired.
>     final long startTime = monotonicNow();
>     if (startTime - lastBlockReport <= dnConf.blockReportInterval) {
>       return null;
>     }
> {code}
> Many tests trigger an immediate block report via {{BPServiceActor#triggerBlockReportForTests}}
which sets {{lastBlockReport = 0}}. However if the machine was restarted recently then startTime
may be less than {{dnConf.blockReportInterval}} and the block report is not sent.
> {{Time#monotonicNow}} uses {{System#nanoTime}} which represents time elapsed since an
arbitrary origin. The time should be used only for comparison with other values returned by
{{System#nanoTime}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message