hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo Nicholas Sze (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8156) Add/implement necessary APIs even we just have the system default schema
Date Wed, 22 Apr 2015 00:32:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506104#comment-14506104
] 

Tsz Wo Nicholas Sze commented on HDFS-8156:
-------------------------------------------

This one is much better.  Thanks.  Some minor comments:
- Should the DEFAULT_CODEC_NAME be "RS"?
{code}
   private static final String DEFAULT_CODEC_NAME = "rs";
-  private static final String DEFAULT_SCHEMA_NAME = "SYS-DEFAULT-RS-6-3";
+  private static final String DEFAULT_SCHEMA_NAME = "RS-6-3";
{code}
- Please remove the comment.  Otherwise, the generated javadoc won't look good.
{code}
+  /**
+   * Most common and general parameters found in typical erasure codes:
+   * numDataUnits, numParityUnits, chunkSize
+   */
{code}
- Please refactor try-catch(NumberFormatException) statements to a method so that numDataUnits,
numParityUnits and chunkSize can all use it.

> Add/implement necessary APIs even we just have the system default schema
> ------------------------------------------------------------------------
>
>                 Key: HDFS-8156
>                 URL: https://issues.apache.org/jira/browse/HDFS-8156
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>         Attachments: HDFS-8156-v1.patch, HDFS-8156-v2.patch, HDFS-8156-v3.patch, HDFS-8156-v4.patch,
HDFS-8156-v5.patch, HDFS-8156-v6.patch, HDFS-8156-v7.patch
>
>
> According to the discussion here, this issue was repurposed and modified.
> This is to add and implement some necessary APIs even we just have the system default
schema, to resolve some TODOs left for HDFS-7859 and HDFS-7866 as they're still subject to
further discussion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message