hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xinwei Qin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8156) Define some system schemas in codes
Date Fri, 17 Apr 2015 06:51:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499359#comment-14499359
] 

Xinwei Qin  commented on HDFS-8156:
-----------------------------------

Patch looks fine. Just a minor comment:
{code}
-      FSNDNCacheOp.removeCachePool(this, cacheManager, cachePoolName,
-          logRetryCache);
+      FSNDNCacheOp.removeCachePool(this, cacheManager, cachePoolName, logRetryCache);
{code}
{code}
-      createEncryptionZoneInt(src, metadata.getCipher(),
-          keyName, logRetryCache);
+      createEncryptionZoneInt(src, metadata.getCipher(), keyName, logRetryCache);
{code}
These two modifications have no relationship with this issue, you'd better remove it out.

> Define some system schemas in codes
> -----------------------------------
>
>                 Key: HDFS-8156
>                 URL: https://issues.apache.org/jira/browse/HDFS-8156
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>         Attachments: HDFS-8156-v1.patch, HDFS-8156-v2.patch, HDFS-8156-v3.patch
>
>
> This is to define and add some system schemas in codes, and also resolve some TODOs left
for HDFS-7859 and HDFS-7866 as they're still subject to further discussion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message