hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rakesh R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8136) Client gets and uses EC schema when reads and writes a stripping file
Date Fri, 17 Apr 2015 14:37:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499915#comment-14499915

Rakesh R commented on HDFS-8136:

Thanks [~kaisasak], patch looks fine. I've few comments, please see:
# Please start the testcase name with small letter. For example, instead of {{TestFileEmpty}}
can use {{testFileEmpty}}. Please do this for all the occurances.
# Can we simplify the assertion using {{assertEquals}} for the below cases:
+    if (readLen != writeBytes) {
+      Assert.fail("The length of file is not correct.");
+    }

+      if (getByte(i) != buf[i]) {
+        Assert.fail("Byte at i = " + i + " is wrongly written.");
+      }

> Client gets and uses EC schema when reads and writes a stripping file
> ---------------------------------------------------------------------
>                 Key: HDFS-8136
>                 URL: https://issues.apache.org/jira/browse/HDFS-8136
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HDFS-7285
>            Reporter: Kai Zheng
>            Assignee: Kai Sasaki
>         Attachments: HDFS-8136.1.patch, HDFS-8136.2.patch
> Discussed with [~umamaheswararao] and [~vinayrpet], in client when reading and writing
a stripping file, it can invoke a separate call to NameNode to request the EC schema associated
with the EC zone where the file is in. Then the schema can be used to guide the reading and
writing. Currently it uses hard-coded values.
> Optionally, as an optimization consideration, client may cache schema info per file or
per zone or per schema name. We could add schema name in {{HdfsFileStatus}} for that.

This message was sent by Atlassian JIRA

View raw message