hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8133) Improve readability of deleted block check
Date Wed, 22 Apr 2015 11:39:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506898#comment-14506898
] 

Hudson commented on HDFS-8133:
------------------------------

FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #171 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/171/])
HDFS-8133. Improve readability of deleted block check (Daryn Sharp via Colin P. McCabe) (cmccabe:
rev 997408eaaceef20b053ee7344468e28cb9a1379b)
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlocksMap.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfoContiguous.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockInfo.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt


> Improve readability of deleted block check
> ------------------------------------------
>
>                 Key: HDFS-8133
>                 URL: https://issues.apache.org/jira/browse/HDFS-8133
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.0.0-alpha
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 2.8.0
>
>         Attachments: HDFS-8133.patch
>
>
> The current means of checking if a block is deleted is checking if its block collection
is null.  A more readable approach is an isDeleted method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message